-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
group orders: display deposit, tolerance only if necessary #1076
base: master
Are you sure you want to change the base?
Conversation
Todos:
|
Actually, the markup is also calculated for the deposit included in the gross price:
At least there should be an option to exclude the deposit from the markup, like
|
Generally, I think those are good points. However, they will lead to merge conflicts and therefore more effort needed with #1073.
I'd prefer a different approach here: The more interesting number is the price without deposit, and adding another column will have negative effects on small (mobile) screens. That's why I'd suggest showing the price without deposit instead and adding a small symbol (e.g. a bottle) next to the price of articles with deposit, with an onclick+onhover tooltip that shows the deposit, like
|
In the current foodsoft version, it is not visible for ordergroups during ordering, if articles contain a deposit and ordergroups may think the article is more expensive. Tolerances are currently shown for all articles, even for articles without tolerance, which makes the view unnecessarily complex. This PR resolves both issues:
Tolerances and deposit are not shown if there is none of them:
An additional column is displayed for the deposit if there is at least one article in the order with deposit. This is important for the ordergroups so that they know that the price shown includes a deposit.
If there is at least one article with tolerance (unit quantity > 1), additional columns appear with tolerance information only at corresponding articles.