group orders: display deposit, tolerance only if necessary #767
mjavurekAnnotations
10 errors and 1 warning
|
test:
app/models/concerns/price_calculation.rb#L6
Lint/UnusedMethodArgument: Unused method argument - `include_deposit`. If it's necessary, use `_` or `_include_deposit` as an argument name to indicate that it won't be used. If it's unnecessary, remove it. You can also write as `gross_price(*)` if you want the method to accept any arguments but don't care about them.
|
|
test:
app/models/concerns/price_calculation.rb#L6
Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment.
|
|
test:
app/models/concerns/price_calculation.rb#L6
Lint/DeprecatedConstants: Use `true` instead of `TRUE`, deprecated since Ruby 2.4.
|
|
test:
app/models/concerns/price_calculation.rb#L16
Layout/IndentationWidth: Use 2 (not 3) spaces for indentation.
|
|
test:
app/models/concerns/price_calculation.rb#L16
Lint/UselessAssignment: Useless assignment to variable - `include_deposit`.
|
|
test:
app/models/concerns/price_calculation.rb#L16
Layout/SpaceAroundOperators: Surrounding space missing for operator `=`.
|
|
test:
app/models/concerns/price_calculation.rb#L16
Lint/DeprecatedConstants: Use `false` instead of `FALSE`, deprecated since Ruby 2.4.
|
|
test:
app/models/concerns/price_calculation.rb#L24
Lint/DeprecatedConstants: Use `false` instead of `FALSE`, deprecated since Ruby 2.4.
|
|
test:
app/models/concerns/price_calculation.rb#L25
Layout/TrailingWhitespace: Trailing whitespace detected.
|
|
test:
app/models/order.rb#L1
Metrics/ClassLength: Class has too many lines. [308/304]
|
|
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|