Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: news about Transboundary Gathering Summary #384

Merged

Conversation

chosww
Copy link
Contributor

@chosww chosww commented Aug 22, 2024

@chosww chosww requested a review from greatislander August 22, 2024 18:34
@chosww
Copy link
Contributor Author

chosww commented Aug 22, 2024

Hey @greatislander, it seems like floe project doesn't have preview site and I don't have permission to merge this change. What would be the best way to show the changes to Dana before we merge the change?

@greatislander
Copy link
Contributor

Hey @greatislander, it seems like floe project doesn't have preview site and I don't have permission to merge this change. What would be the best way to show the changes to Dana before we merge the change?

Hi @chosww — as is the case with Weavly, this site won't generate deploy previews if the pull request comes from a fork (it's on Cloudflare). So you will need to log in to Cloudflare and create a deploy for your fork to show @dayotte the work you've done here. I'm available if you need help with this.

Copy link
Contributor

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know when this should be merged.

@greatislander greatislander merged commit 1ff6b47 into fluid-project:dev Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants