decision log move and include in readme #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fivetran-joemarkiewicz
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks for applying these updates @fivetran-reneeli! Just a few notes before approving this. Let me know if you have any questions. Thanks!
README.md
Outdated
| @@ -149,6 +149,12 @@ A small team of analytics engineers at Fivetran develops these dbt packages. How | |||
|
|
|||
| We highly encourage and welcome contributions to this package. Check out [this dbt Discourse article](https://discourse.getdbt.com/t/contributing-to-a-dbt-package/657) on the best workflow for contributing to a package! | |||
|
|
|||
| ## Opinionated Modelling Decisions | |||
|
|
|||
| The ServiceNow Connector provides thousands of tables. We developed our data models based on the tables with highest usage across Fivetran customers. | |||
There was a problem hiding this comment.
I don't think this is necessary as this is a decision we apply to all our data models.
Co-authored-by: Joe Markiewicz <[email protected]>
|
Ready for re-review! |
fivetran-joemarkiewicz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#6
This PR will result in the following new package version:
v0.1.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR #7 documents the DECISIONLOG in the README and moves the DECISIONLOG out of the /models folder, so that customers will be able to easily find it as a resource.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
not necessary since only markdown files were changed
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃