fix(theme): apply docs sidebar_class_name in DocCard + better dogfooding
#10909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: bug fix
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +4.1 kB (+0.04%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +4.08 kB (+0.04%) Total Size: 11.5 MB
ℹ️ View Unchanged
|
2 tasks
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
What worked before: using
sidebar_class_nameon a doc of an autogenerated sidebar category propagates to the respective theme sidebar item (supporting both regular items and category index doc).What this PR adds is the usage of that same class on the
<DocCard>component used to render the generated index page. This enables styling for both category index and regular items:Fix #10864
Fix #10095
Test Plan
CI + argos + dogfood + deploy preview
Test links