Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1974

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Add prerequisites for practice exercises #1974

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e1ce69
Add prerequisites for 'transpose' exercise
TomPradat Oct 31, 2022
480920e
Add prerequisites for 'largest-series-product' exercise
TomPradat Nov 2, 2022
246548c
Add prerequisites for exercise 'scale-generator'
TomPradat Nov 9, 2022
118baee
Increase 'transpose' practice exercise difficulty
TomPradat Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,12 @@
"name": "Scale Generator",
"uuid": "b9c586e8-998b-4f5d-ab98-a08be29a9f19",
"practices": [],
"prerequisites": [],
"prerequisites": [
"classes",
"arrays",
"strings",
"array-transformations"
],
Comment on lines +888 to +893
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My solution : https://exercism.org/tracks/javascript/exercises/scale-generator/solutions/TomPradat

I found mstange22's and the proof solution more concise and understandable so I filled the prerequisites according to these

"difficulty": 3,
"topics": ["loops", "pattern_recognition", "strings", "arrays"]
},
Expand All @@ -910,7 +915,13 @@
"name": "Largest Series Product",
"uuid": "1f84305d-ea76-4fe2-9858-3b53576d683d",
"practices": [],
"prerequisites": [],
"prerequisites": [
"strings",
"numbers",
"errors",
"conditionals",
"array-transformations"
],
Comment on lines +918 to +924
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/largest-series-product/solutions/TomPradat

"difficulty": 7,
"topics": [
"conditionals",
Expand All @@ -927,8 +938,8 @@
"name": "Transpose",
"uuid": "9c140fb7-cc8b-411b-b613-a0e0081a9c3f",
"practices": [],
"prerequisites": [],
"difficulty": 1,
"prerequisites": ["arrays", "for-loops", "strings", "conditionals"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/transpose/solutions/TomPradat

I'm kinda facing a dilemma here : Either we consider that we can solve this exercise like I did, i.e without array-transformations and/or array-analysis or we add the two latest prerequisites (as used in the majority of community solutions I've seen) but it's a shame given the difficulty of the exercise.

Either ways, I'd recommend increasing the difficulty to 3 or 4. This exercise resembles matrix whose difficulty is 3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets increase the difficulty and lets NOT add the array prereqs. If it's harder, people are bound to have more experience, so we'll see more people solving it your way.

3 is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

118baee

"difficulty": 3,
"topics": [
"arrays",
"lists",
Expand Down