-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisites for practice exercises #1974
Add prerequisites for practice exercises #1974
Conversation
Dear TomPradatThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
@@ -927,7 +927,7 @@ | |||
"name": "Transpose", | |||
"uuid": "9c140fb7-cc8b-411b-b613-a0e0081a9c3f", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["arrays", "for-loops", "strings", "conditionals"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/transpose/solutions/TomPradat
I'm kinda facing a dilemma here : Either we consider that we can solve this exercise like I did, i.e without array-transformations
and/or array-analysis
or we add the two latest prerequisites (as used in the majority of community solutions I've seen) but it's a shame given the difficulty of the exercise.
Either ways, I'd recommend increasing the difficulty to 3 or 4. This exercise resembles matrix whose difficulty is 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets increase the difficulty and lets NOT add the array prereqs. If it's harder, people are bound to have more experience, so we'll see more people solving it your way.
3 is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"prerequisites": [ | ||
"strings", | ||
"numbers", | ||
"errors", | ||
"conditionals", | ||
"array-transformations" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16f7f9d
to
246548c
Compare
"prerequisites": [ | ||
"classes", | ||
"arrays", | ||
"strings", | ||
"array-transformations" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My solution : https://exercism.org/tracks/javascript/exercises/scale-generator/solutions/TomPradat
I found mstange22's and the proof solution more concise and understandable so I filled the prerequisites according to these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomPradat can you also increase the difficulty? Feel free to merge if you can, or ping me and I will.
Done @SleeplessByte ! I cannot merge on my own though |
This aims to add prerequisites for some exercises in #984