Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1974

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

TomPradat
Copy link
Contributor

@TomPradat TomPradat commented Oct 31, 2022

This aims to add prerequisites for some exercises in #984

@github-actions
Copy link
Contributor

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@@ -927,7 +927,7 @@
"name": "Transpose",
"uuid": "9c140fb7-cc8b-411b-b613-a0e0081a9c3f",
"practices": [],
"prerequisites": [],
"prerequisites": ["arrays", "for-loops", "strings", "conditionals"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/transpose/solutions/TomPradat

I'm kinda facing a dilemma here : Either we consider that we can solve this exercise like I did, i.e without array-transformations and/or array-analysis or we add the two latest prerequisites (as used in the majority of community solutions I've seen) but it's a shame given the difficulty of the exercise.

Either ways, I'd recommend increasing the difficulty to 3 or 4. This exercise resembles matrix whose difficulty is 3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets increase the difficulty and lets NOT add the array prereqs. If it's harder, people are bound to have more experience, so we'll see more people solving it your way.

3 is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +913 to +919
"prerequisites": [
"strings",
"numbers",
"errors",
"conditionals",
"array-transformations"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomPradat TomPradat force-pushed the feature/TP/prerequisites branch from 16f7f9d to 246548c Compare November 9, 2022 20:55
Comment on lines +888 to +893
"prerequisites": [
"classes",
"arrays",
"strings",
"array-transformations"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My solution : https://exercism.org/tracks/javascript/exercises/scale-generator/solutions/TomPradat

I found mstange22's and the proof solution more concise and understandable so I filled the prerequisites according to these

@TomPradat TomPradat marked this pull request as ready for review December 11, 2022 09:46
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomPradat can you also increase the difficulty? Feel free to merge if you can, or ping me and I will.

@TomPradat
Copy link
Contributor Author

@TomPradat can you also increase the difficulty? Feel free to merge if you can, or ping me and I will.

Done @SleeplessByte ! I cannot merge on my own though

@SleeplessByte SleeplessByte merged commit 00c7606 into exercism:main Jan 4, 2023
@TomPradat TomPradat deleted the feature/TP/prerequisites branch January 5, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants