Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default check register for shared interrupts (IDFGH-14469) #15243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

udoudou
Copy link
Contributor

@udoudou udoudou commented Jan 21, 2025

Description

The CPU interrupt signal of the ESP chip is very limited, and some basic peripherals in IDF have registered and used some interrupt signals. Usually in more complex application scenarios, it is easy to encounter the problem of being unable to register interrupts. For this situation, there are generally two ways to deal with it:

  1. The peripheral driver registered by the application layer sets the registration of shared interrupts;
  2. If it is a multi-core chip, some peripheral driver interrupts can also be registered on other cores.

However, the current shared interrupt logic design has defects. If the driver does not explicitly set statusreg when registering a shared interrupt, different peripherals assigned to the same interrupt signal, as long as one peripheral generates an interrupt, all peripheral interrupt programs will be executed once, which will cause some peripheral driver processing logic to be abnormal (such as SPI master driver).

There are two ideas to solve this problem:

  1. Adjust the peripheral driver code itself to adapt it to the shared interrupt situation;
  2. Set a default statusreg for the shared interrupt and only call the peripheral interrupt program triggered by the interrupt.

This modification corresponds to the second point above.

Related

Testing

Based on the examples/peripherals/lcd/spi_lcd_touch routine, I modified the initialization of spi to a shared interrupt, and added the initialization of the i2c peripheral to a shared interrupt, and periodically executed i2c transmission to cause a crash.
I tested this modification on the ESP32/ESP32S2/ESP32S3/ESP32C2/ESP32C3/ESP32C6 platform and no crash occurred


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

github-actions bot commented Jan 21, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello udoudou, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 3e440f9

@github-actions github-actions bot changed the title Set default check register for shared interrupts Set default check register for shared interrupts (IDFGH-14469) Jan 21, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 21, 2025
@udoudou udoudou force-pushed the feat/shared_interrupt_setting_default_check_register branch from 05bd439 to 3e440f9 Compare January 21, 2025 10:04
@SoucheSouche
Copy link
Collaborator

Hi @udoudou, thanks for submitting the PR. We will take a look at it shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants