Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve estimate for remainding time #1993

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Improve estimate for remainding time #1993

merged 2 commits into from
Jan 30, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 30, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol self-assigned this Jan 30, 2025
@Eddasol Eddasol linked an issue Jan 30, 2025 that may be closed by this pull request
Improve estimated duration #1863
Closed
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the fix-est-dur branch 2 times, most recently from 811d659 to 2c77dba Compare January 30, 2025 08:14
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Jan 30, 2025
@Eddasol Eddasol added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 30, 2025
@Eddasol Eddasol mentioned this pull request Jan 30, 2025
Closed
@Eddasol
Copy link
Contributor Author

Eddasol commented Jan 30, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/13048516490

@Eddasol
Copy link
Contributor Author

Eddasol commented Jan 30, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/13048812128

@Eddasol
Copy link
Contributor Author

Eddasol commented Jan 30, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit faa27d6 into equinor:main Jan 30, 2025
14 checks passed
@Eddasol Eddasol deleted the fix-est-dur branch January 30, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality database-change Will require migration frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve estimated duration
2 participants
@Eddasol @aeshub