Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix some issues with output token funkeyos #803

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

juliadin
Copy link
Contributor

@juliadin juliadin commented Nov 1, 2023

During the last Pull request, I overlooked some issues that I tried to rectify in this one:

  • Mainly documentation issues
  • Remove mapping for NeoGeo because it is not supported

Sorry for the confusion

Copy link

github-actions bot commented Nov 1, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:juliadin/igir#fix_outputToken_funkeyos" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #803 (a9f589c) into main (ee50d93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          85       85           
  Lines        5200     5200           
  Branches     1183     1183           
=======================================
  Hits         4862     4862           
  Misses        320      320           
  Partials       18       18           
Files Coverage Δ
src/modules/argumentsParser.ts 98.12% <ø> (ø)
src/types/gameConsole.ts 100.00% <ø> (ø)

@juliadin juliadin marked this pull request as ready for review November 1, 2023 15:54
@emmercm emmercm merged commit 69ebb3a into emmercm:main Nov 5, 2023
51 checks passed
@juliadin juliadin deleted the fix_outputToken_funkeyos branch November 6, 2023 09:04
juliadin added a commit to juliadin/igir that referenced this pull request Nov 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants