Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Output token twmenu #804

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Conversation

juliadin
Copy link
Contributor

@juliadin juliadin commented Nov 1, 2023

Output Token {twmenu} for 3DS Rom Launcher TWiLightMenu++ (homebrew) @ GitHub

if these are not desired (as in 'we do not want to clutter the outputTokens with too many systems') please let me know. Right now I am contributing the ones i'd find useful myself and I am 'going through the attic' to see what I could contribute.

Seeing how they are organized, putting more and more in could potentially clutter the code immensely.

Also: I added two GameConsole matches. Please reject them if they are not written the way you'd like them.

Copy link

github-actions bot commented Nov 1, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:juliadin/igir#outputToken_twmenu" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@juliadin juliadin marked this pull request as ready for review November 1, 2023 21:46
Copy link
Owner

@emmercm emmercm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my merging of #803 may have caused a conflict here.

README.md Outdated Show resolved Hide resolved
docs/usage/desktop/twmenu.md Outdated Show resolved Hide resolved
src/modules/argumentsParser.ts Outdated Show resolved Hide resolved
@juliadin juliadin requested a review from emmercm November 7, 2023 21:39
@emmercm emmercm enabled auto-merge (squash) November 10, 2023 00:14
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #804 (342e71f) into main (537d5ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          85       85           
  Lines        5200     5205    +5     
  Branches     1183     1184    +1     
=======================================
+ Hits         4862     4867    +5     
  Misses        320      320           
  Partials       18       18           
Files Coverage Δ
src/modules/argumentsParser.ts 98.12% <ø> (ø)
src/types/gameConsole.ts 100.00% <100.00%> (ø)
src/types/outputFactory.ts 100.00% <100.00%> (ø)

@emmercm emmercm merged commit de64253 into emmercm:main Nov 10, 2023
50 checks passed
@juliadin juliadin deleted the outputToken_twmenu branch November 10, 2023 09:08
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants