-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Output token twmenu #804
Conversation
🧪 Branch testing instructionsThis pull request can be tested locally with the following command: npm exec --yes -- "github:juliadin/igir#outputToken_twmenu" [commands..] [options] Comment generated by the Pull Request Commenter workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my merging of #803 may have caused a conflict here.
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 85 85
Lines 5200 5205 +5
Branches 1183 1184 +1
=======================================
+ Hits 4862 4867 +5
Misses 320 320
Partials 18 18
|
🔒 Inactive pull request lockThis pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Comment generated by the GitHub Lock Issues workflow. |
Output Token
{twmenu}
for 3DS Rom Launcher TWiLightMenu++ (homebrew) @ GitHubif these are not desired (as in 'we do not want to clutter the outputTokens with too many systems') please let me know. Right now I am contributing the ones i'd find useful myself and I am 'going through the attic' to see what I could contribute.
Seeing how they are organized, putting more and more in could potentially clutter the code immensely.
Also: I added two GameConsole matches. Please reject them if they are not written the way you'd like them.