[Fleet] Improve support for Agentless in Fleet UI #183045

criamico · 2024-05-09T13:51:14Z

Closes #180375

Summary

Expand support for Agentless in Fleet UI. Implemented on this PR:

Agent policies created with supports_agentless (added in [Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709) are now marked as is_managed
Added support for deployment_modes.agentless.enabled and hide_in_deployment_modes introduced with [Change Proposal] Define requirements for agentless support package-spec#684:
- hide_in_deployment_modes shows/hides variables in agentless/default UI
- deployment_modes.agentless.enabled: true determines an integration as enabled for agentless

Notes

In this PR, an integration enabled for serverless is still added to the default agentless policy.
Integrations enabled for agentless don't display any specific "agentless" form yet. That part is TBD

Testing

Run local env for agentless

Verify that new settings are honoured in integration policy

Use the compiled package with new properties defined in Add support for definitions related to deployment modes package-spec#738 agentless_test_package-1.0.1-rc1.zip (Packages in this comment)

Upload it to Kibana:

 curl -k -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' https://localhost:5601/api/fleet/epm/packages -u elastic_serverless:changeme --data-binary @agentless_test_package-0.0.1.zip

Check that the variable marked with hide_in_deployment_modes: "agentless" are not visible
Check that the agent policies selector is not visible

Verify that agent policies with `supports_agentless` are marked as managed

Create a new policy with supports_agentless

POST kbn:/api/fleet/agent_policies
{
  "name": "Test - Agentless policy",
  "namespace": "default",
  "supports_agentless": true
}

Check that the created policy has is_managed = true

Try to change the value to false - an error is thrown

PUT kbn:/api/fleet/agent_policies/<policy_id>
{
  "name": "Test - Agentless policy",
  "namespace": "default",
  "supports_agentless": false
}

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

apmmachine · 2024-05-09T13:51:27Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

criamico · 2024-05-14T08:26:17Z

@elasticmachine merge upstream

criamico · 2024-05-15T07:45:31Z

@elasticmachine merge upstream

criamico · 2024-05-16T15:02:45Z

/ci

kfirpeled · 2024-05-20T18:33:34Z

cc: @Omolola-Akinleye , @seanrathier

criamico · 2024-05-21T13:53:02Z

/ci

criamico · 2024-05-21T14:29:40Z

@elasticmachine merge upstream

criamico · 2024-05-21T14:34:23Z

/ci

criamico · 2024-05-22T08:44:38Z

I built a test package with some example inputs that has the new fields specified in elastic/package-spec#738 - I built two different versions to make sure that both will work on kibana:

Version 0.0.1 uses the new agentless fields
agentless_test_package-0.0.1.zip
Version 1.0.1-rc also uses the new default fields:
agentless_test_package-1.0.1-rc1.zip

These files can be used to test the above changes.

elasticmachine · 2024-05-22T08:45:29Z

Pinging @elastic/fleet (Team:Fleet)

criamico · 2024-05-22T08:45:39Z

@elasticmachine merge upstream

criamico · 2024-05-22T09:27:13Z

I tested the UI with the example integrations in ESS as well to make sure that the variables are shown/hidden as requested:

Test with the version 0.0.1 (only new agentless fields):
Test with 1.0.1-rc that has also the default fields:

criamico · 2024-05-23T07:34:45Z

@elasticmachine merge upstream

kibana-ci · 2024-05-23T08:51:12Z

💚 Build Succeeded

Buildkite Build
Commit: 1e9f792

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1188	1189	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.3MB	1.3MB	+1.1KB

Unknown metric groups

API count

id	before	after	diff
`fleet`	1309	1310	+1

History

💚 Build #211434 succeeded 6c84910
💚 Build #211267 succeeded 5e0e6d4
💔 Build #210528 failed 5669cf4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

juliaElastic

LGTM

kpollich · 2024-05-23T10:46:58Z

Should the "create agent policy" step be shown for agentless policies? I would expect that an agentless integration would always be placed on the agentless hardcoded policy for now in these changes.

criamico · 2024-05-23T11:14:09Z

Should the "create agent policy" step be shown for agentless policies? I would expect that an agentless integration would always be placed on the agentless hardcoded policy for now in these changes.

@kpollich It's actually like that already. Here's a screenshot on serverless with agentless flag enabled:

Outside of this conditions (ESS, serverless with agentless not enabled) the agent policy selector is shown, as there is nothing to prevent an agentless integration to be installed.

kpollich · 2024-05-23T11:54:30Z

Perfect - thanks for clarifying, @criamico 👍

kpollich

LGTM - happy to see tests on both client + server side here. 🚀

kpollich · 2024-05-23T11:55:50Z

x-pack/plugins/fleet/server/services/agent_policy.test.ts

@@ -278,7 +278,7 @@ describe('Agent policy', () => {
      );
    });

-    it('should not throw error if support_agentless is set if agentless feature flag is set in serverless', async () => {
+    it('should create a policy with is_managed true if agentless feature flag is set and in serverless env', async () => {


Thanks for updating this test case based on the new logic added.

Fixes #184191 ## Summary With merge of #183045 some tests related to agentless started failing in main. I realized that there was a missing condition in a form, so this PR adds that condition and fixes the failing test. Note: the test wasn't flaky, it was failing on each run after merge. For some reason it never failed on the branch, however there was a concurrent merge of [another PR](b86039e) that touched the same UI and that could have something to do with it. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>

Improve support for Agentless in Fleet UI

567f6ba

criamico self-assigned this May 9, 2024

criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label May 9, 2024

Improve support for agentless integrations

4937496

kibanamachine and others added 3 commits May 14, 2024 04:26

Merge branch 'main' into 180375_Improve_support_for_agentless

15d7194

Remove unused props in package_policy form

ec6256f

Hide inputs based on hide_in_deployment_modes

7e471cf

kibanamachine and others added 6 commits May 15, 2024 03:45

Merge branch 'main' into 180375_Improve_support_for_agentless

73eb3c3

Add unit test for package_policy_input_panel

542fb4f

Changes to setup_technology and unit test

846586b

Adjust visibility by new property and fix tests

5c83f19

Improve unit test for package_policy_input_panel

92e06dd

Remove code hiding policy templates

5669cf4

Update useAgentless hook and improve naming

9d6b4b6

Fix tests

80cdc68

Merge branch 'main' into 180375_Improve_support_for_agentless

5e0e6d4

criamico marked this pull request as ready for review May 22, 2024 08:45

criamico requested review from a team as code owners May 22, 2024 08:45

Merge branch 'main' into 180375_Improve_support_for_agentless

6c84910

criamico added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels May 22, 2024

Merge branch 'main' into 180375_Improve_support_for_agentless

1e9f792

juliaElastic approved these changes May 23, 2024

View reviewed changes

kpollich approved these changes May 23, 2024

View reviewed changes

seanrathier approved these changes May 23, 2024

View reviewed changes

criamico merged commit 5cdb132 into elastic:main May 24, 2024
19 checks passed

kibanamachine added the backport:skip This commit does not require backporting label May 24, 2024

criamico deleted the 180375_Improve_support_for_agentless branch May 24, 2024 07:18

criamico mentioned this pull request Jul 29, 2024

[Fleet] Finalize generic support for agentless integration policies in Fleet policy editor #183863

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Improve support for Agentless in Fleet UI #183045

[Fleet] Improve support for Agentless in Fleet UI #183045

criamico commented May 9, 2024 •

edited

Loading

apmmachine commented May 9, 2024

criamico commented May 14, 2024

criamico commented May 15, 2024

criamico commented May 16, 2024

kfirpeled commented May 20, 2024

criamico commented May 21, 2024

criamico commented May 21, 2024

criamico commented May 21, 2024

criamico commented May 22, 2024 •

edited

Loading

elasticmachine commented May 22, 2024

criamico commented May 22, 2024

criamico commented May 22, 2024

criamico commented May 23, 2024

kibana-ci commented May 23, 2024

API count

juliaElastic left a comment

kpollich commented May 23, 2024

criamico commented May 23, 2024 •

edited

Loading

kpollich commented May 23, 2024

kpollich left a comment

kpollich May 23, 2024

[Fleet] Improve support for Agentless in Fleet UI #183045

[Fleet] Improve support for Agentless in Fleet UI #183045

Conversation

criamico commented May 9, 2024 • edited Loading

Summary

Notes

Testing

Verify that new settings are honoured in integration policy

Verify that agent policies with supports_agentless are marked as managed

Checklist

apmmachine commented May 9, 2024

🤖 GitHub comments

criamico commented May 14, 2024

criamico commented May 15, 2024

criamico commented May 16, 2024

kfirpeled commented May 20, 2024

criamico commented May 21, 2024

criamico commented May 21, 2024

criamico commented May 21, 2024

criamico commented May 22, 2024 • edited Loading

elasticmachine commented May 22, 2024

criamico commented May 22, 2024

criamico commented May 22, 2024

criamico commented May 23, 2024

kibana-ci commented May 23, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

juliaElastic left a comment

Choose a reason for hiding this comment

kpollich commented May 23, 2024

criamico commented May 23, 2024 • edited Loading

kpollich commented May 23, 2024

kpollich left a comment

Choose a reason for hiding this comment

kpollich May 23, 2024

Choose a reason for hiding this comment

criamico commented May 9, 2024 •

edited

Loading

Verify that agent policies with `supports_agentless` are marked as managed

criamico commented May 22, 2024 •

edited

Loading

criamico commented May 23, 2024 •

edited

Loading