[Fleet] Unskip test for agentless integrations #184308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
commented
May 27, 2024
| if (agentCount !== 0 && !isAgentlessIntegration(packageInfo) && formState !== 'CONFIRM') { | ||
| if ( | ||
| agentCount !== 0 && | ||
| !(isAgentlessIntegration(packageInfo) || isAgentlessPackagePolicy(packagePolicy)) && |
There was a problem hiding this comment.
I noticed that in the previous PR I forgot to add isAgentlessPackagePolicy(packagePolicy), fixing it now.
criamico
commented
May 27, 2024
| } | ||
| if (path === '/api/fleet/agent_download_sources') { | ||
| return Promise.resolve({ data: { items: [] } }); | ||
| } |
There was a problem hiding this comment.
I was getting an error regarding these endpoint not being mocked.
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @criamico |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184191
Summary
With merge of #183045 some tests related to agentless started failing in main. I realized that there was a missing condition in a form, so this PR adds that condition and fixes the failing test.
Note: the test wasn't flaky, it was failing on each run after merge. For some reason it never failed on the branch, however there was a concurrent merge of another PR that touched the same UI and that could have something to do with it.
Checklist