[EuiEmptyPrompt] Fix styles to work correctly with custom larger breakpoints #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
empty-prompt-breakpoint-fix
branch
from
4a45981 to
5e96fd4
Compare
💚 Build Succeeded
History
|
mgadewoll
approved these changes
Aug 1, 2024
|
GAH i forgot the revert me commit. going to push that to main |
|
Thanks for the super quick fix. Much appreciated 🥇 |
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Aug 5, 2024
`v95.5.0` ⏩ `v95.6.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.6.0`](https://github.com/elastic/eui/releases/v95.6.0) - Updated `EuiIcon` with a new `crossInCircle` glyph ([#7924](elastic/eui#7924)) **Bug fixes** - Fixed `EuiEmptyPrompt` to correctly collapse and expand responsively when used with custom breakpoints larger than the default `xl` breakpoint ([#7935](elastic/eui#7935)) **Accessibility** - Improved the experience of `EuiModal` by ensuring nested `EuiPopover` closes on `Escape` keypress instead of the modal ([#7939](elastic/eui#7939)) **CSS-in-JS conversions** - Converted `EuiDatePicker` to Emotion ([#7937](elastic/eui#7937)) - Removed `$euiDatePickerCalendarWidth` - Removed `$euiDatePickerPadding` - Removed `$euiDatePickerGap` - Removed `$euiDatePickerCalendarColumns` - Removed `$euiDatePickerButtonSize` - Removed `$euiDatePickerMinControlWidth` - Removed `$euiDatePickerMaxControlWidth` - Removed `@mixin datePickerCaret` - Removed `@mixin datePickerArrow`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@kpatticha reported an issue in APM where EuiEmptyPrompt stops displaying with desktop/larger styles. This is because APM uses a custom
xxl: 1600breakpoint, and EuiEmptyPrompt's styles previously used aneuiBreakpoint('l', 'xl')which was not accounting for larger breakpoints.Switching the component to
euiMinBreakpointresolves the issue for consumers with custom larger breakpoints.QA
.euiEmptyPrompt__mainin devtoolsflex-direction: row-reverseCSS is correctly wrapped in@media only screen and (min-width: 992px), and not a min+max width media queryGeneral checklist
- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Checked in both light and dark modes- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)