Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] EuiEmptyPrompt horizontal layout is not working #188200

Closed
kpatticha opened this issue Jul 12, 2024 · 7 comments
Closed

[APM] EuiEmptyPrompt horizontal layout is not working #188200

kpatticha opened this issue Jul 12, 2024 · 7 comments
Labels
apm:custom-dashboards blocked bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@kpatticha
Copy link
Contributor

The issue appears in APM, while in infra it renders as expected
https://eui.elastic.co/#/display/empty-prompt#layout

Current

image

Expected

image

While it should be https://eui.elastic.co/#/display/empty-prompt#layout


Found in
apm • public/components/app/infra_overview/infra_tabs/empty_prompt.tsx:
  40        icon={<NoResultsIllustration />}
  41:       layout="horizontal"
  42        title={

apm • public/components/app/service_dashboards/empty_dashboards.tsx:
  38          }
  39:         layout="horizontal"
  40          color="plain"

apm • public/components/app/service_inventory/multi_signal_inventory/table/no_entities_empty_state.tsx:
  54              }
  55:             layout="horizontal"
  56              color="plain"
@kpatticha kpatticha added the good first issue low hanging fruit label Jul 12, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 12, 2024
@kpatticha kpatticha added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jul 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 15, 2024
@smith smith added apm:custom-dashboards bug Fixes for quality problems that affect the customer experience labels Jul 15, 2024
@smith
Copy link
Contributor

smith commented Jul 15, 2024

FYI this seems to be working correctly when it's enabled in hosts:
CleanShot 2024-07-15 at 14 50 23@2x

(I don't think it's the same code, but it displays correctly.)

@kpatticha
Copy link
Contributor Author

@smith yes, I mentioned that in the description. The horizontal layout seems to be broken only in APM for some reason.

@kpatticha kpatticha changed the title [APM] EuiEmptyPrompt horizonal layout is not working [APM] EuiEmptyPrompt horizontal layout is not working Jul 22, 2024
@kpatticha kpatticha self-assigned this Jul 29, 2024
@kpatticha
Copy link
Contributor Author

I'm going to tackle this one first as the root problem for https://github.com/elastic/observability-dev/issues/3779

@kpatticha
Copy link
Contributor Author

This one is currently blocked as it's a issue in the EUI.

I talked with them and they will fix it. In the meantime, I'm moving this to backlog.

Why is happening only in APM?
EUI defines breakpoints xs, s, m, l, xl as default theme but APM on Kibana uses an additional breakpoint xxl (file) breaking the media rule which is refined here

ex

@media only screen and (min-width: 992px) and (max-width: 1599px) {
    .css-nuy00t-euiEmptyPrompt__main-horizontal-l-l {
        flex-direction: row-reverse;
    }
}

The functionality of euiBreakpoint in EUI needs to updated on handle breakpoints

@smith
Copy link
Contributor

smith commented Aug 5, 2024

Thanks @kpatticha! I'll unassign you for now.

@kpatticha
Copy link
Contributor Author

The fix has been already merged elastic/eui#7935 and I verified the fix locally
image
closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:custom-dashboards blocked bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

3 participants