Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping for shard_stats.total_count #107471

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

philippkahr
Copy link
Contributor

Should fix this: elastic/beats#38891 (review)

@philippkahr philippkahr requested a review from a team as a code owner April 15, 2024 13:33
@elasticsearchmachine
Copy link
Collaborator

@philippkahr please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.14.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 15, 2024
@miltonhultgren
Copy link
Contributor

You'll also need to update the file x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/MonitoringTemplateRegistry.java as in this PR https://github.com/elastic/elasticsearch/pull/103709/files (just increment that counter by one) 👍🏼

@philippkahr philippkahr merged commit 212e203 into main Apr 15, 2024
4 of 25 checks passed
@philippkahr philippkahr deleted the philippkahr-patch-1 branch April 15, 2024 14:41
@nik9000
Copy link
Member

nik9000 commented Apr 15, 2024

Hey friends! You merged this without letting CI finish and this happens to have broken starting ES. That kind of broke things for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Stats Statistics tracking and retrieval APIs external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants