Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node.stats.indices.shard_stats.total_count to monitoring-es-mb template #114472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renshuki
Copy link
Contributor

@renshuki renshuki commented Oct 10, 2024

Resolves #114470

Also as mentioned in #114470:

I can see there was this PR (#107471) and the ES side to add the field to the monitor mappings. However, I can see it was added as cluster_stats.indices.shards_stats.total_count, not elasticsearch.node.stats.indices.shard_stats.total_count. Is it a mistake?

I don't see this field (cluster_stats.indices.shards_stats.total_count) being used anywhere in the monitoring data.

and it seems to overlap with cluster_stats.indices.shards.total:

"shards_stats": {
"properties": {
"total_count": {
"type": "long"
}
}
},
"shards": {
"properties": {
"total": {
"path": "elasticsearch.cluster.stats.indices.shards.count",
"type": "alias"
}
}
},
"count": {
"path": "elasticsearch.cluster.stats.indices.total",
"type": "alias"
}
}

If you can confirm that cluster_stats.indices.shards_stats.total_count is not used, I don't mind adding a commit to remove it.

@renshuki renshuki requested a review from a team as a code owner October 10, 2024 05:55
@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 10, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Stack Monitoring v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch.node.stats.indices.shard_stats.total_count missing in ES monitoring template
2 participants