Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip https://www.weave.works in link checking #2114

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Skip https://www.weave.works in link checking #2114

merged 1 commit into from
Apr 30, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Apr 30, 2020 •
edited
Loading

Description

Fixes #2088

Note

Found that that I missed watching the related configuration files for link checkers in previous PR.

Regex testing was done in https://play.golang.org/p/CAHGMAhbouq

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras mentioned this pull request Apr 30, 2020
Closed
@sayboras sayboras changed the title Skip https://www.weave.works for the time being Skip https://www.weave.works in link checking Apr 30, 2020
@sayboras
Skip https://www.weave.works for the time being
43efafc 
Watch the related configuration files for link checkers
@sayboras sayboras force-pushed the bugfix/link-check-redirect branch 2 times, most recently from 92c2cfe to 43efafc Compare April 30, 2020 10:28
dholbach
dholbach approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍏

@dholbach dholbach merged commit 547e454 into eksctl-io:master Apr 30, 2020
@sayboras sayboras deleted the bugfix/link-check-redirect branch April 30, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholbach dholbach dholbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link check error due to too many redirect/request
2 participants
@sayboras @dholbach