Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link check error due to too many redirect/request #2088

Closed
sayboras opened this issue Apr 27, 2020 · 4 comments · Fixed by #2114
Closed

Link check error due to too many redirect/request #2088

sayboras opened this issue Apr 27, 2020 · 4 comments · Fixed by #2114
Labels
kind/bug priority/backlog Not staffed at the moment. Help wanted.

Comments

@sayboras
Copy link
Contributor

sayboras commented Apr 27, 2020

What happened?
Link check github action error

What you expected to happen?
Github action link check should be successful

Occasionally, the below issue happens

https://github.com/weaveworks/eksctl/pull/2084/checks?check_run_id=621818814
https://github.com/weaveworks/eksctl/runs/621864468
https://github.com/weaveworks/eksctl/pull/2093/checks?check_run_id=621990410

image

@sayboras
Copy link
Contributor Author

As contributor might not have permission to re-run the failed job, one new git push is required to re-run the job.

@sayboras sayboras changed the title Link check error due to too many redirect Link check error due to too many redirect/request Apr 27, 2020
@martina-if martina-if added the priority/backlog Not staffed at the moment. Help wanted. label Apr 27, 2020
@sayboras
Copy link
Contributor Author

sayboras commented Apr 28, 2020

Not important as this issue is less likely to happen after the PR #2093 is merged, which will reduce the number of unneccessary checks. Thanks to @martina-if @dholbach 🎉

I just take a look at the upstream tool, seems like redirecting issue is also happening raviqqe/liche#32

@dholbach
Copy link
Contributor

Maybe let's just exclude weave.works in the link-checking for now.

@sayboras
Copy link
Contributor Author

@dholbach thanks for your input, just raise one PR for the same #2114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/backlog Not staffed at the moment. Help wanted.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants