fix: update tracker support and services cones per project CAD info #661

wdconinc · 2024-03-11T21:46:19Z

Briefly, what does this PR introduce?

This PR adds the outer support/services cone and places the cones and barrels in their actual intended positions. I'm marking this as a bugfix since the placement was completely wrong (with tracks in some regions going through two support cylinders...).

TODO:

fix: InnerMPGDBarrel rmin 51.25 -> 55 cm; zmax 135 -> 143 cm #663
Change pfRICH outer radius #673
- this is not really a dependency, but if the radius of that system increases, we want to figure it out before putting in the services
fix: mv dRICH from 195cm to 198cm #668
fix: rotate DRICH by 30 degrees #683
feat: dRICH sensor boxes in more realistic sector segments #684

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators @sly2j

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes, it adds the project's estimate of the equivalent aluminum thickness of the services.

wdconinc · 2024-03-11T21:47:53Z

CAD model and marked up drawing at https://cad.onshape.com/documents/b9b389bae84aec586d8b3cb2/w/1ec43063ccb2db2d3583a345/e/ae6cffdbeeea3bf0cbd5a09a

wdconinc · 2024-03-12T01:06:50Z

Overlaps:

=== Overlaps for Default ===
 = Overlap ov00000: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportCylEndcapN2C_14 overlapping world_volume/EcalEndcapN_21/EcalEndcapN_envelope_0 ovlp=1.2488
 = Overlap ov00001: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportCylEndcapN2C_14 overlapping world_volume/EcalEndcapN_21/ring12_1 ovlp=1.2488
 = Overlap ov00002: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_2/Envelope_box_vol_0 ovlp=0.960703
 = Overlap ov00003: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_10/Envelope_box_vol_0 ovlp=0.960703
 = Overlap ov00004: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_6/Envelope_box_vol_0 ovlp=0.960703
 = Overlap ov00005: world_volume/InnerMPGDBarrelSubAssembly_8/InnerMPGDBarrel_0/InnerMPGDBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/OuterSupportConeEndcapN_10 ovlp=0.883848
 = Overlap ov00006: world_volume/MiddleSiTrackerSubAssembly_5/SagittaSiBarrel_0/SagittaSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapN_2 ovlp=0.671716
 = Overlap ov00007: world_volume/OuterSiTrackerSubAssembly_6/OuterSiBarrel_0/OuterSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapN_2 ovlp=0.636361
 = Overlap ov00008: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_5/Envelope_box_vol_0 ovlp=0.487628
 = Overlap ov00009: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_3/Envelope_box_vol_0 ovlp=0.487628
 = Overlap ov00010: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_9/Envelope_box_vol_0 ovlp=0.487628
 = Overlap ov00011: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_1/Envelope_box_vol_0 ovlp=0.487628
 = Overlap ov00012: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_11/Envelope_box_vol_0 ovlp=0.487628
 = Overlap ov00013: world_volume/MiddleSiTrackerSubAssembly_5/SagittaSiBarrel_0/SagittaSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapP_3 ovlp=0.414088
 = Overlap ov00014: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_0/Envelope_box_vol_0 ovlp=0.27
 = Overlap ov00015: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_4/Envelope_box_vol_0 ovlp=0.27

wdconinc · 2024-03-12T17:48:55Z

Analysis and todo of overlaps:

= Overlap ov00000: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportCylEndcapN2C_14 overlapping world_volume/EcalEndcapN_21/EcalEndcapN_envelope_0 ovlp=1.2488
= Overlap ov00001: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportCylEndcapN2C_14 overlapping world_volume/EcalEndcapN_21/ring12_1 ovlp=1.2488
EcalEndcapN is 12-sided (inscribed circle with radius 65 cm), and only smallest radius fits in cylindrical support cylinder.
- check whether EcalEndcapN is indeed up to 65 cm, since detector parameter table says 63 cm
- check with Roland whether this is intended as cylindrical or at that point is 12-sided around EcalEndcapN
= Overlap ov00004: world_volume/InnerTrackerSupport_assembly_13/TrackerSupportDiskEndcapP_20 overlapping world_volume/DIRC_14/DIRCModule_6/Envelope_box_vol_0 ovlp=0.960703
EndcapP services/support disk (180.8 to 183.4 cm) overlaps with DIRC (which can go up to 185 cm)
- check with Roland on assumptions for services/support disk placement
= Overlap ov00005: world_volume/InnerMPGDBarrelSubAssembly_8/InnerMPGDBarrel_0/InnerMPGDBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/OuterSupportConeEndcapN_10 ovlp=0.883848
Inner MPGD Barrel overlaps with services at the equivalent thickness specified
- ~~check with Roland on how this fits without interference:~~ Inner MPGD Barrel has moved outwards in radius
= Overlap ov00006: world_volume/MiddleSiTrackerSubAssembly_5/SagittaSiBarrel_0/SagittaSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapN_2 ovlp=0.671716
= Overlap ov00013: world_volume/MiddleSiTrackerSubAssembly_5/SagittaSiBarrel_0/SagittaSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapP_3 ovlp=0.414088
Sagitta Si Barrel overlaps with services at the equivalent thickness specified
- check with Roland on how this fits without interference
= Overlap ov00007: world_volume/OuterSiTrackerSubAssembly_6/OuterSiBarrel_0/OuterSiBarrel_layer1_0 overlapping world_volume/InnerTrackerSupport_assembly_13/InnerSupportConeEndcapN_2 ovlp=0.636361
Outer Si Barrel overlaps with services at the equivalent thickness specified
- check with Roland on how this fits without interference

wdconinc · 2024-03-12T18:08:25Z

Overlap between services/support cylinder (rmin = 65 cm, rmax = rmin + 26 mm) and EcalEndcapN (rmax = 65 cm but because of 12-sided nature this only avoids interference at the center of each side, not at the corners).

veprbl · 2024-03-12T20:19:31Z

Overlap between services/support cylinder (rmin = 65 cm, rmax = rmin + 26 mm) and EcalEndcapN (rmax = 65 cm but because of 12-sided nature this only avoids interference at the center of each side, not at the corners).

This part of services is important for us. I suppose, it should somehow change the shape from round to dodecadon. Should we request additional details from the project on that?

wdconinc · 2024-03-12T22:16:40Z

Should we request additional details from the project on that?

We should get some more details later this week.

wdconinc · 2024-03-14T14:53:57Z

Updated CAD at https://cad.onshape.com/documents/c0ed227baac48c145c49cf1e/w/d0907e24cd4dc810e5d737d3/e/7bbf426811fe41884a26ab05

Drawing:

veprbl · 2024-03-16T00:42:31Z

One question about the last drawing: the 8.2 mm thickness is just the mechanical support itself, so we would still need the density estimates and routing in CAD for cabling?

wdconinc · 2024-03-16T01:47:36Z

The thickness is equivalent aluminum thickness based on total number and diameter of cables. So it doesn't need a lower density. In reality it will be thicker and a stacked bundle with a lower average density.

veprbl · 2024-03-16T01:57:54Z

The thickness is equivalent aluminum thickness based on total number and diameter of cables. So it doesn't need a lower density. In reality it will be thicker and a stacked bundle with a lower average density.

Should be copper? Also, we don't need to prepare special, "effective" geometry. It would be fine to have a conductor volume from the regular CAD design to which we then assign a proportion of conductor/isolator/air to the material?

wdconinc · 2024-03-16T02:07:16Z

The effective model is all there is. There is no routing that we can import. The CAD figures above are all there is that has somewhat correct effective material volume. A previous version was outlines/max extents only.

wdconinc · 2024-03-18T13:04:05Z

Looks like this now:

ShujieL · 2024-03-21T01:36:10Z

Please email me once this and other relevant geometry updates are merged, I will then update the material map. Thanks!

veprbl · 2024-04-01T06:45:32Z

I did some studies on effect at the negative rapidity for this PR https://indico.bnl.gov/event/22883/contributions/89707/attachments/53617/91737/eeemcal_update.pdf
It's not too bad.

wdconinc · 2024-04-08T19:18:15Z

The current routing of the services long the DRICH looks something like this, in section view:

the slope in the DRICH vessel is not as steep as the service routing seems to imply,
the "snout" slope in the DRICH vessel is also mismatched with the service routing.

…s<double>::epsilon()

…22598/

…uminum_thickness

for more information, see https://pre-commit.ci

github-actions bot added the topic: tracking label Mar 11, 2024

wdconinc force-pushed the services_effective_aluminum_thickness branch from b6f993a to 1bcb9d7 Compare March 12, 2024 17:49

wdconinc mentioned this pull request Mar 13, 2024

fix: InnerMPGDBarrel rmin 51.25 -> 55 cm; zmax 135 -> 143 cm #663

Merged

7 tasks

wdconinc force-pushed the services_effective_aluminum_thickness branch from 0fadd72 to 356c7ad Compare March 14, 2024 14:50

wdconinc force-pushed the services_effective_aluminum_thickness branch from e04e4e9 to 83b3034 Compare March 18, 2024 21:10

wdconinc mentioned this pull request Mar 21, 2024

fix: mv dRICH from 195cm to 198cm #668

Merged

7 tasks

wdconinc force-pushed the services_effective_aluminum_thickness branch 3 times, most recently from 6d10958 to 936a028 Compare March 27, 2024 21:12

wdconinc added this to the 24.04.0 milestone Mar 27, 2024

wdconinc force-pushed the services_effective_aluminum_thickness branch 2 times, most recently from 47b3fbd to ec64f62 Compare April 5, 2024 12:40

veprbl modified the milestones: 24.04.0, 24.05.0 Apr 8, 2024

github-actions bot added the topic: forward Positive-rapidity detectors (hadron-going side) label Apr 8, 2024

wdconinc added 14 commits April 8, 2024 21:51

fix: supports/services as of Services Material Budget 24.03.13.stp

9347143

fix: nudge TrackerSupportCylEndcapN_rmin2 to avoid EcalEndcapN overlap

25d85ae

fix: updates per Services Material Budget 24.03.13.stp

fb07286

fix: inner detector barrel support cylinder has length of DIRC

65d0125

fix: inherit phimin/phimax from support parent

ab63f3e

fix: add services routing around DRICH

38e7dac

feat: support cone rmin/rmax with priority over rmin1/2, rmax1/2

7d24089

fix: use TGeoShape::Tolerance() = 1e-10 instead of std::numeric_limit…

14a5525

…s<double>::epsilon()

fix: spacing

db74e9a

fix: consistent polycone z-plane ordering

a67ee95

fix: correct zmax determination when rmax is given

58d20a6

fix: DRICH sensorbox rmin to 108 cm per https://indico.bnl.gov/event/…

77c95ac

…22598/

fix: route services around DRICH without overlaps

c662362

fix: InnerSupportCone Al thickness =-0.5 mm for OuterSiBarrel overlap

d382b24

wdconinc force-pushed the services_effective_aluminum_thickness branch from 65f19f8 to d382b24 Compare April 9, 2024 02:51

wdconinc added 2 commits April 16, 2024 09:54

fix: clang-format

3f5225d

Merge remote-tracking branch 'origin/main' into services_effective_al…

f2f9317

…uminum_thickness

wdconinc marked this pull request as ready for review April 16, 2024 18:52

wdconinc requested a review from veprbl April 16, 2024 18:54

wdconinc mentioned this pull request Apr 22, 2024

dRICH Extrusion Box azimuthal span 42 degrees #712

Merged

2 tasks

veprbl and others added 2 commits April 26, 2024 15:30

Merge branch 'main' into services_effective_aluminum_thickness

e0e10fe

[pre-commit.ci] auto fixes from pre-commit.com hooks

c882cde

for more information, see https://pre-commit.ci

github-actions bot added topic: barrel Mid-rapidity detectors topic: calorimetry labels Apr 26, 2024

support_service_craterlake.xml: remove the fudge

601c652

veprbl approved these changes Apr 28, 2024

View reviewed changes

wdconinc added this pull request to the merge queue Apr 29, 2024

Merged via the queue into main with commit 81162e0 Apr 29, 2024
109 checks passed

wdconinc deleted the services_effective_aluminum_thickness branch April 29, 2024 03:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update tracker support and services cones per project CAD info #661

fix: update tracker support and services cones per project CAD info #661

wdconinc commented Mar 11, 2024 •

edited

Loading

wdconinc commented Mar 11, 2024

wdconinc commented Mar 12, 2024

wdconinc commented Mar 12, 2024 •

edited

Loading

wdconinc commented Mar 12, 2024

veprbl commented Mar 12, 2024

wdconinc commented Mar 12, 2024

wdconinc commented Mar 14, 2024

veprbl commented Mar 16, 2024 •

edited

Loading

wdconinc commented Mar 16, 2024

veprbl commented Mar 16, 2024

wdconinc commented Mar 16, 2024

wdconinc commented Mar 18, 2024

ShujieL commented Mar 21, 2024

veprbl commented Apr 1, 2024

wdconinc commented Apr 8, 2024

fix: update tracker support and services cones per project CAD info #661

fix: update tracker support and services cones per project CAD info #661

Conversation

wdconinc commented Mar 11, 2024 • edited Loading

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

wdconinc commented Mar 11, 2024

wdconinc commented Mar 12, 2024

wdconinc commented Mar 12, 2024 • edited Loading

wdconinc commented Mar 12, 2024

veprbl commented Mar 12, 2024

wdconinc commented Mar 12, 2024

wdconinc commented Mar 14, 2024

veprbl commented Mar 16, 2024 • edited Loading

wdconinc commented Mar 16, 2024

veprbl commented Mar 16, 2024

wdconinc commented Mar 16, 2024

wdconinc commented Mar 18, 2024

ShujieL commented Mar 21, 2024

veprbl commented Apr 1, 2024

wdconinc commented Apr 8, 2024

wdconinc commented Mar 11, 2024 •

edited

Loading

wdconinc commented Mar 12, 2024 •

edited

Loading

veprbl commented Mar 16, 2024 •

edited

Loading