Skip to content

Commit

Permalink
fix: update tracker support and services cones per project CAD info (#…
Browse files Browse the repository at this point in the history
…661)

### Briefly, what does this PR introduce?
This PR adds the outer support/services cone and places the cones and
barrels in their actual intended positions. I'm marking this as a bugfix
since the placement was completely wrong (with tracks in some regions
going through two support cylinders...).

TODO:
- [x] #663
- [x] #673
- this is not really a dependency, but if the radius of that system
increases, we want to figure it out before putting in the services
- [x] #668 
- [x] #683
- [x] #684

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @sly2j 

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Yes, it adds the project's estimate of the equivalent aluminum thickness
of the services.

---------

Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Apr 29, 2024
1 parent 823e91f commit 81162e0
Show file tree
Hide file tree
Showing 5 changed files with 638 additions and 86 deletions.
2 changes: 1 addition & 1 deletion compact/pid/drich.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<constant name="DRICH_rmax2" value="ForwardPIDRegion_rmax"/> <!-- cylinder radius -->
<!-- sensor boxes: extrusions of the tank, to hold the sensors and their services -->
<constant name="DRICH_sensorbox_length" value="50.0*cm"/> <!-- z-length of the extrusion -->
<constant name="DRICH_sensorbox_rmin" value="DRICH_rmax1 + 2*cm"/> <!-- lower radial limit of the extrusion -->
<constant name="DRICH_sensorbox_rmin" value="108*cm"/> <!-- lower radial limit of the extrusion -->
<constant name="DRICH_sensorbox_rmax" value="DRICH_rmax2 + 5*cm"/> <!-- upper radial limit of the extrusion -->
<constant name="DRICH_sensorbox_dphi" value="42*degree"/> <!-- azimuthal width of the extrusion -->
<!-- aerogel+filter geometry -->
Expand Down
5 changes: 3 additions & 2 deletions compact/tracking/definitions_craterlake.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
<constant name="ForwardTOF_zmin" value="ForwardTOFRegion_zmin + ForwardTOFRegion_length - ForwardTOF_length - 1*cm"/>

<comment> Service/Support setup </comment>
<constant name="TrackerSupportCyl_rmin1" value="TrackerEndcapDisk_rmax + 0.2*cm"/>
<constant name="TrackerSupportCyl_rmin2" value="InnerMPGDBarrel_rmin - 1.2*cm"/>
<constant name="TrackerSupportCyl_rmin1" value="TrackerEndcapDisk_rmax + 2*cm"/> <comment> Ref: Services Material Budget 24.03.04..stp -- 450.00 mm </comment>
<constant name="TrackerSupportCylEndcapN_rmin2" value="BackwardPIDRegion_rmax + 4.5*cm"/> <comment> Ref: Services Material Budget 24.03.13.stp -- 670.00 mm, nudged 5 mm </comment>
<constant name="TrackerSupportCylEndcapP_rmin2" value="ForwardTOFRegion_maxR + 2*cm"/> <comment> Ref: Services Material Budget 24.03.04..stp -- 520.00 mm </comment>
<comment> These may belong in definitions.xml </comment>
<constant name="InnerTrackerEndcapP_zmax" value="CentralTrackingRegionP_zmax"/>
<constant name="InnerTrackerEndcapN_zmax" value="CentralTrackingRegionN_zmax"/>
Expand Down
Loading

0 comments on commit 81162e0

Please sign in to comment.