fix(ci): run clang-tidy with extra-args -std=c++20 #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
1149-ci-clang-tidy-iwyu-fails-on-main-due-to-std++17
branch
from
f241d96 to
f9e1691
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
approved these changes
Nov 27, 2023
wdconinc
deleted the
1149-ci-clang-tidy-iwyu-fails-on-main-due-to-std++17
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This should address the clang-tidy issues on main (and likely soon in a PR). clang-tidy runs without errors in my local eic-shell test setup now.
I considered adding the logic to allow the builds to be against a variable that encodes the C++ standard, but that quickly ran out of hand (see discussion on doing this for compilers). With one standard every three years, I think it's reasonable to deal with this as we go. We only support C++20 now anyway.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.