Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI clang-tidy-iwyu fails on main due to std++17 #1149

Closed
wdconinc opened this issue Nov 25, 2023 · 0 comments · Fixed by #1150
Closed

CI clang-tidy-iwyu fails on main due to std++17 #1149

wdconinc opened this issue Nov 25, 2023 · 0 comments · Fixed by #1150

Comments

@wdconinc
Copy link
Contributor

Environment: (where does this bug occur, have you tried other environments)

  • Which branch (often main for latest released): main
  • Which version (or HEAD for the most recent on git): HEAD
  • Any specific OS or system where the issue occurs? CI

Steps to reproduce: (give a step by step account of how to trigger the bug)

  1. https://github.com/eic/EICrecon/actions/runs/6981919620/job/19000371388

Expected Result: (what do you expect when you execute the steps above)

There should be no clang-tidy errors on main.

Actual Result: (what do you get when you execute the steps above)

Many errors, mostly due to C++20 concepts used in with -extra-arg='-std=c++17'.
@wdconinc wdconinc mentioned this issue Nov 25, 2023
Merged
7 tasks
@wdconinc wdconinc linked a pull request Nov 25, 2023 that will close this issue
fix(ci): run clang-tidy with extra-args -std=c++20 #1150
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2023
@wdconinc
fix(ci): run clang-tidy with extra-args -std=c++20 (#1150)
4c362b1 
### Briefly, what does this PR introduce?
This should address the clang-tidy issues on main (and likely soon in a
PR). clang-tidy runs without errors in my local eic-shell test setup
now.

I considered adding the logic to allow the builds to be against a
variable that encodes the C++ standard, but that quickly ran out of hand
(see discussion on doing this for compilers). With one standard every
three years, I think it's reasonable to deal with this as we go. We only
support C++20 now anyway.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #1149)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): run clang-tidy with extra-args -std=c++20 eic/EICrecon
1 participant
@wdconinc