Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use trace log for details ops #613

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Feb 7, 2025

Close #612

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cloudxxx8 cloudxxx8 requested a review from weichou1229 February 7, 2025 07:07
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.29%. Comparing base (b1150ce) to head (0963b13).

Files with missing lines Patch % Lines
internal/driver/driver.go 0.00% 3 Missing ⚠️
internal/driver/modbusclient.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   40.29%   40.29%           
=======================================
  Files           7        7           
  Lines         670      670           
=======================================
  Hits          270      270           
  Misses        354      354           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weichou1229 weichou1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichou1229 weichou1229 merged commit 3ffb092 into edgexfoundry:main Feb 10, 2025
3 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-612 branch February 10, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The data reading details logs should be TRACE level not INFO level
3 participants