Merge pull request #613 from cloudxxx8/issue-612

fix: Use trace log for details ops
edgexfoundry · Feb 10, 2025 · 3ffb092 · 3ffb092
2 parents b1150ce + 0963b13
commit 3ffb092
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/internal/driver/driver.go b/internal/driver/driver.go
@@ -1,6 +1,6 @@
 // -*- Mode: Go; indent-tabs-mode: t -*-
 //
-// Copyright (C) 2018-2023 IOTech Ltd
+// Copyright (C) 2018-2025 IOTech Ltd
 //
 // SPDX-License-Identifier: Apache-2.0
 
@@ -134,7 +134,7 @@ func (d *Driver) HandleReadCommands(deviceName string, protocols map[string]mode
 	for i, req := range reqs {
 		res, err := handleReadCommandRequest(deviceClient, req)
 		if err != nil {
-			driver.Logger.Infof("Read command failed. Cmd:%v err:%v \n", req.DeviceResourceName, err)
+			driver.Logger.Errorf("Read command failed. Cmd:%v err:%v \n", req.DeviceResourceName, err)
 			return responses, err
 		}
 
@@ -164,7 +164,7 @@ func handleReadCommandRequest(deviceClient DeviceClient, req sdkModel.CommandReq
 	if err != nil {
 		return result, err
 	} else {
-		driver.Logger.Infof("Read command finished. Cmd:%v, %v \n", req.DeviceResourceName, result)
+		driver.Logger.Tracef("Read command finished. Cmd:%v, %v \n", req.DeviceResourceName, result)
 	}
 
 	return result, nil
@@ -219,7 +219,7 @@ func handleWriteCommandRequest(deviceClient DeviceClient, req sdkModel.CommandRe
 		return fmt.Errorf("handle write command request failed, err: %v", err)
 	}
 
-	driver.Logger.Infof("Write command finished. Cmd:%v \n", req.DeviceResourceName)
+	driver.Logger.Tracef("Write command finished. Cmd:%v \n", req.DeviceResourceName)
 	return nil
 }
 

diff --git a/internal/driver/modbusclient.go b/internal/driver/modbusclient.go
@@ -1,6 +1,6 @@
 // -*- Mode: Go; indent-tabs-mode: t -*-
 //
-// Copyright (C) 2018-2021 IOTech Ltd
+// Copyright (C) 2018-2025 IOTech Ltd
 //
 // SPDX-License-Identifier: Apache-2.0
 
@@ -107,7 +107,7 @@ func (c *ModbusClient) GetValue(commandInfo interface{}) ([]byte, error) {
 		return response, err
 	}
 
-	driver.Logger.Info(fmt.Sprintf("Modbus client GetValue's results %v", response))
+	driver.Logger.Tracef("Modbus client GetValue's results %v", response)
 
 	return response, nil
 }
@@ -141,7 +141,7 @@ func (c *ModbusClient) SetValue(commandInfo interface{}, value []byte) error {
 	if err != nil {
 		return err
 	}
-	driver.Logger.Info(fmt.Sprintf("Modbus client SetValue successful, results: %v", result))
+	driver.Logger.Tracef("Modbus client SetValue successful, results: %v", result)
 
 	return nil
 }