Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented launching procedure (#11). #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johannesbulin
Copy link
Collaborator

Updated launching mechanism (see #11)

  • Added environment handler and environment pipeline classes.
  • Added Application base class.
  • Arch classes now have methods instead of class methods. Will now update Job objects and may create additional EnvHandler objects.
  • Reworked Launcher classes.
  • Removed Benchmark classes and tests as these are broken due to the extensive changes and will be reimplemented later.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 86.01190% with 47 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (c0b6ccb) to head (c5775ce).

Files with missing lines Patch % Lines
ifsbench/launcher/bashlauncher.py 20.68% 23 Missing ⚠️
ifsbench/arch.py 86.36% 6 Missing ⚠️
ifsbench/launcher/launcher.py 72.72% 6 Missing ⚠️
ifsbench/application.py 88.57% 4 Missing ⚠️
ifsbench/launcher/srunlauncher.py 90.00% 4 Missing ⚠️
ifsbench/env.py 95.83% 3 Missing ⚠️
ifsbench/job.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   78.15%   75.68%   -2.47%     
==========================================
  Files          22       27       +5     
  Lines        1927     1822     -105     
==========================================
- Hits         1506     1379     -127     
- Misses        421      443      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants