feat: implement DataPlaneSignalingAPI #3951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+111
to
+113
| var msg = typeTransformerRegistry.transform(suspendMessage, DataFlowSuspendMessage.class) | ||
| .onFailure(f -> monitor.warning("Error transforming %s: %s".formatted(DataFlowSuspendMessage.class, f.getFailureDetail()))) | ||
| .orElseThrow(InvalidRequestException::new); |
Check notice
Code scanning / CodeQL
Unread local variable
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 71.74% 73.32% +1.57%
==========================================
Files 919 958 +39
Lines 18457 19233 +776
Branches 1037 1087 +50
==========================================
+ Hits 13242 14102 +860
+ Misses 4756 4670 -86
- Partials 459 461 +2 ☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
Mar 4, 2024
extensions/data-plane/data-plane-signaling/data-plane-signaling-api/build.gradle.kts
Outdated
Show resolved
Hide resolved
...ata-plane/data-plane-spi/src/main/java/org/eclipse/edc/connector/dataplane/spi/DataFlow.java
Outdated
Show resolved
Hide resolved
…g-api/build.gradle.kts Co-authored-by: ndr_brt <[email protected]>
wolf4ood
approved these changes
Mar 4, 2024
paullatzelsperger
force-pushed
the
feat/3911_implement_signaling_api_controller
branch
from
f1f45f5 to
e7a79ad
Compare
paullatzelsperger
deleted the
feat/3911_implement_signaling_api_controller
branch
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR implements the actual API controller of the Signaling API that delegates down to collaborator services
Why it does that
Full functionality of the signaling API
Further notes
DataFlowsfor which no source was found, is now possible. Previously that would have resulted in a failure.DataFlowsnow takes an optionalreasonargument that gets persisted in the data flow entity.Linked Issue(s)
Closes #3911
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.