feat: Implement SignalingApi controller #3953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-api/build.gradle.kts Co-authored-by: ndr_brt <[email protected]>
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
added
enhancement
paullatzelsperger
deleted the
feat/3911_implement_signaling_api_controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR implements the actual API controller of the Signaling API that delegates down to collaborator services
Why it does that
Full functionality of the signaling API
Further notes
DataFlowsfor which no source was found, is now possible. Previously that would have resulted in a failure.DataFlowsnow takes an optionalreasonargument that gets persisted in the data flow entity.Note this PR is an exact duplicate of #3951. I ran into some weird git/caching issue, so I had to recreate the PR.
Linked Issue(s)
Closes #3911
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.