chore(workspace-plugin): display additional confirmation before cloning a project #1203

vitaliy-guliy · 2021-08-26T11:02:31Z

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Asks the user whether he trust the authors of the project.

Since che-theia does not work wit the latest upstream changes eclipse-che/che#20366, it was temporary switched to specific commit. This change will be reverted before merge.

THEIA_COMMIT_SHA=863c7382d70cc4f74108a3563a92a66b47cb121a

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20249

How to test this PR?

Go to the latest comment from che-bot, click Try It button.
Create a workspace with the devfile

apiVersion: 1.0.0
metadata:
  name: java-minimal
projects:
  - name: web-java-spring-petclinic
    source:
      location: 'https://github.com/che-samples/java-spring-petclinic'
      type: git
components:
  - type: cheEditor
    alias: che-theia
    reference: https://gist.githubusercontent.com/vitaliy-guliy/0abd17e4418ef06dd8f0e155d6dc33c7/raw/8b498d37dba1a0c2a6a594fd0053ec7198789def/editor.meta.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

…ng a project Signed-off-by: Vitaliy Gulyy <[email protected]>

codecov · 2021-08-26T11:18:24Z

Codecov Report

Merging #1203 (4728f58) into main (c299f59) will decrease coverage by 0.16%.
The diff coverage is 19.21%.

@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
- Coverage   32.78%   32.61%   -0.17%     
==========================================
  Files         290      295       +5     
  Lines        9885     9994     +109     
  Branches     1457     1473      +16     
==========================================
+ Hits         3241     3260      +19     
- Misses       6641     6731      +90     
  Partials        3        3

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...he-server/src/node/che-server-http-service-impl.ts	`0.00% <0.00%> (ø)`
...-che-server/src/node/che-server-remote-api-impl.ts	`38.88% <0.00%> (ø)`
...browser/contribution/exec-terminal-contribution.ts	`0.00% <0.00%> (ø)`
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b2e3a...4728f58. Read the comment docs.

benoitf · 2021-08-26T11:28:16Z

FYI with devworkspace clone is not performed by the editor

che-bot · 2021-08-26T11:44:09Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-26T13:50:42Z

FYI with devworkspace clone is not performed by the editor

Who is cloning the project then?
As dashboard doesn't clone the project, the alternative editor should be able to do this.

azatsarynnyy · 2021-08-26T13:55:06Z

FYI with devworkspace clone is not performed by the editor

Who is cloning the project then?
As dashboard doesn't clone the project, the alternative editor should be able to do this.

@vitaliy-guliy see devfile/devworkspace-operator#371

…ng a project Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy · 2021-08-26T14:10:30Z

Then this fix will be specific only for che-theia editor.
If it's a devworkspace + che-theia, the popup should not appear at all.

For devworkspace we could find another way. This prompt could be implemented on the dashboard.

che-bot · 2021-08-26T14:52:57Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

…eia/7.35.1 Signed-off-by: Vitaliy Gulyy <[email protected]>

che-bot · 2021-08-27T12:30:27Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-27T21:41:44Z

[crw-ci-test]

che-bot · 2021-08-27T21:43:59Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-27T21:49:51Z

[crw-ci-test]

che-bot · 2021-08-27T21:52:51Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-27T21:57:01Z

@dmytro-ndp crw-ci-e2e-happy-path-tests still trying to download quay.io/eclipse/happy-path:nightly image.
Are happy-path scripts cached somewhere?

vitaliy-guliy · 2021-08-27T21:57:26Z

[crw-ci-test --rebuild]

che-bot · 2021-08-27T22:01:45Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-30T07:56:14Z

[crw-ci-test --rebuild]

che-bot · 2021-08-30T07:58:54Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

dmytro-ndp · 2021-08-30T09:23:50Z

[crw-ci-test]

che-bot · 2021-08-30T09:54:39Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-31T14:49:06Z

[crw-ci-test]

che-bot · 2021-08-31T15:19:03Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vitaliy-guliy · 2021-08-31T15:25:53Z

[crw-ci-test]

…branch Signed-off-by: Vitaliy Gulyy <[email protected]>

Signed-off-by: Vitaliy Gulyy <[email protected]>

che-bot · 2021-08-31T16:57:46Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1203
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1203

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Ohrimenko1988 · 2021-09-01T08:20:39Z

The "Happy Path" test has been passed
#1203 (comment) .

From the QE side looks well.

chore(workspace-plugin): display additional confirmation before cloni…

3e5fcee

…ng a project Signed-off-by: Vitaliy Gulyy <[email protected]>

chore(workspace-plugin): display additional confirmation before cloni…

e569ead

…ng a project Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy marked this pull request as ready for review August 26, 2021 15:29

vitaliy-guliy requested review from azatsarynnyy, benoitf, RomanNikitenko, sunix, svor, tsmaeder, vinokurig and vzhukovs as code owners August 26, 2021 15:29

chore(workspace-plugin): bump to theia commit, that is used in che-th…

9516d51

…eia/7.35.1 Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy mentioned this pull request Aug 27, 2021

chore(happy-path-tests): confirm trust git repository authors when necessary eclipse-che/che#20374

Merged

9 tasks

vinokurig approved these changes Aug 31, 2021

View reviewed changes

vitaliy-guliy added 2 commits August 31, 2021 18:38

chore(workspace-plugin): use the same theia commit as it in the main …

50eb5c8

…branch Signed-off-by: Vitaliy Gulyy <[email protected]>

Merge branch 'main' into ask-before-cloning-a-project

4728f58

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy merged commit 042927f into main Sep 1, 2021

vitaliy-guliy deleted the ask-before-cloning-a-project branch September 1, 2021 08:21

che-bot added this to the 7.36 milestone Sep 1, 2021

RomanNikitenko mentioned this pull request Sep 2, 2021

chore: Rename next build job. Send notification of its failure to mattermost #1209

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(workspace-plugin): display additional confirmation before cloning a project #1203

chore(workspace-plugin): display additional confirmation before cloning a project #1203

vitaliy-guliy commented Aug 26, 2021 •

edited

Loading

codecov bot commented Aug 26, 2021 •

edited

Loading

benoitf commented Aug 26, 2021

che-bot commented Aug 26, 2021

vitaliy-guliy commented Aug 26, 2021

azatsarynnyy commented Aug 26, 2021

vitaliy-guliy commented Aug 26, 2021

che-bot commented Aug 26, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 30, 2021

che-bot commented Aug 30, 2021

dmytro-ndp commented Aug 30, 2021

che-bot commented Aug 30, 2021

vitaliy-guliy commented Aug 31, 2021

che-bot commented Aug 31, 2021

vitaliy-guliy commented Aug 31, 2021

che-bot commented Aug 31, 2021

Ohrimenko1988 commented Sep 1, 2021

chore(workspace-plugin): display additional confirmation before cloning a project #1203

chore(workspace-plugin): display additional confirmation before cloning a project #1203

Conversation

vitaliy-guliy commented Aug 26, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

codecov bot commented Aug 26, 2021 • edited Loading

Codecov Report

benoitf commented Aug 26, 2021

che-bot commented Aug 26, 2021

vitaliy-guliy commented Aug 26, 2021

azatsarynnyy commented Aug 26, 2021

vitaliy-guliy commented Aug 26, 2021

che-bot commented Aug 26, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

vitaliy-guliy commented Aug 27, 2021

che-bot commented Aug 27, 2021

vitaliy-guliy commented Aug 30, 2021

che-bot commented Aug 30, 2021

dmytro-ndp commented Aug 30, 2021

che-bot commented Aug 30, 2021

vitaliy-guliy commented Aug 31, 2021

che-bot commented Aug 31, 2021

vitaliy-guliy commented Aug 31, 2021

che-bot commented Aug 31, 2021

Ohrimenko1988 commented Sep 1, 2021

vitaliy-guliy commented Aug 26, 2021 •

edited

Loading

codecov bot commented Aug 26, 2021 •

edited

Loading