Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore: Rename next build job. Send notification of its failure to mattermost #1209

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

mkuznyetsov
Copy link
Contributor

Signed-off-by: Mykhailo Kuznietsov [email protected]

What does this PR do?

Rename CI build job to next-build.yaml (To make it similar with other next build jobs in Eclipse Che projects)
Add notification that will be sent to Eclipse MM channel

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@mkuznyetsov mkuznyetsov changed the title Rename next build job. Send notification of its failure to mattermost chore: Rename next build job. Send notification of its failure to mattermost Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1209 (3f4da8f) into main (c299f59) will decrease coverage by 0.16%.
The diff coverage is 19.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   32.78%   32.61%   -0.17%     
==========================================
  Files         290      295       +5     
  Lines        9885     9994     +109     
  Branches     1457     1473      +16     
==========================================
+ Hits         3241     3260      +19     
- Misses       6641     6731      +90     
  Partials        3        3              
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts 0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts 38.88% <0.00%> (ø)
...browser/contribution/exec-terminal-contribution.ts 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042927f...3f4da8f. Read the comment docs.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Thanks!

@che-bot
Copy link
Contributor

che-bot commented Sep 1, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1209
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1209

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@vitaliy-guliy
Copy link
Contributor

I suppose happy-path test are failing because of eclipse-che/che#20374 is not merged yet.
To merge that PR we need to have published che-theia:next to be sure tests are passed.

@RomanNikitenko
Copy link
Member

I suppose happy-path test are failing because of eclipse/che#20374 is not merged yet.
To merge that PR we need to have published che-theia:next to be sure tests are passed.

@vitaliy-guliy
I see that eclipse-che/che#20374 is not ready to merge.

So:

I would say it's better to have both PRs approved first and only then merge.

@azatsarynnyy
Copy link
Member

@mkuznyetsov please wait a bit with merging your changes while we decide internally what we'll do to make the HappyPath green again. We will let you know.

@vitaliy-guliy
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1209
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1209

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkuznyetsov now, it's good to merge

@mkuznyetsov mkuznyetsov merged commit 12374ca into main Sep 2, 2021
@mkuznyetsov mkuznyetsov deleted the ci-notify branch September 2, 2021 12:47
@che-bot che-bot added this to the 7.36 milestone Sep 2, 2021
@azatsarynnyy
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants