-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitize with a reusable Makefile #143
Conversation
To digitize all data ``` cd data make ``` To run the svgdigitizer in parallel on 8 cores, use instead ``` make -j8 ``` We can also only digitize a single data set ``` make generated/svgdigitizer/mello_2018_understanding_J3045/mello_2018_understanding_J3045_p1_f1H_black.csv ``` To digitize data coming from a different source directory than `literature/` use ``` make SOURCE_DIR=/another/path ```
@DunklesArchipel, I believe that this is more flexible and easier than echemdb/svgdigitizer#138. I am not sure if it works well on Windows, so I'll see what the CI thinks about this. |
Btw., this is not software from the 80s but from the 70s ;) [though it did of course not have all these fancy features back then; doing something in parallel was probably not really a thing.] |
Looks great! For example, if you want to convert a file and subsequently create a database with these fictitious functions: filename = `generated/svgdigitizer/mello_2018_understanding_J3045/mello_2018_understanding_J3045_p1_f1H_black.csv`
make(filename) # calls the makefile
create_db(filename) # creates the db from converted files and bibfiles. |
Also some questions/suggestions:
|
Sure. We'd have to work out the details but assuming that make is installed, this is going to work. |
Yes, it should be part of the documentation. I'll add that here.
No. When something is not convertible, the whole process will fail. However, we could change it so that it ignores files that cannot be converted. (I don't recommend that though.)
Yes. Both files need to be present. When a file is missing it is going to complain that a prerequisite of the .json/.csv file is missing.
Yes. That's trivial to add. |
they mean the same but mixing them can lead to cryptic errors
To digitize all data
To run the svgdigitizer in parallel on 8 cores, use instead
We can also only digitize a single data set
To digitize data coming from a different source directory than
literature/
useTODO