Test data for the workflow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilthanki
force-pushed
the
feature/test_data
branch
from
90622d5 to
697bd7c
Compare
pmb59
requested changes
Mar 4, 2025
There was a problem hiding this comment.
@anilthanki I've left few comments.
Can you clarify in the README which input files are not compulsory? For instance, [--celltype_field <celltype_field>] is optional.
Co-authored-by: Pedro Madrigal <[email protected]>
|
@pmb59 and @irisdianauy All ready for review |
pmb59
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
@anilthanki LGTM, just two comments:
here, --celltype_field is optionaldo you mean only for test-droplet? or for both? It looks like it applies only to section 2.- Link in scxa for E-GEOD-9801 is not working.
Thank you @pmb59 both comment addressed Thank you for your review.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #13