-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Carrierwave generate urls. Fixes #123 #151 #155
Conversation
…> true) The current implmentation has issues while Carrierwave already has a working solution. This also make direct_fog_url work with private storage on S3
+1 for this. Resolves a URL-encoding issue we were experiencing. |
+1 |
+1 had issues with encoding and it solved it ! Thanks ! |
+1 |
@nddeluca Have you had a chance of looking at this? |
👍 |
1 similar comment
👍 |
👍 Fixed my encoding issues. |
Let Carrierwave generate urls. Fixes dwilkie#123 dwilkie#151
Anyone want to help maintaining this gem? See #83 |
@dwilkie Sure, I'd like to help. |
@p8 Awesome thanks. You've got full access rights now |
@p8 PM me your email address so you can push to Rubygems |
Thanks! |
@p8, great work! 👍 I know I'm pushing it but cutting a release would be swell :-) |
Done :) |
The url generation by CarrierwaveDirect is complex and has issues (#129, #151).
Carrierwave already generates urls for us.
By letting Carrierwave generate the urls we can remove code from CarrierwaveDirect.
Another benefit is default support for private storage on S3 (#123).
I have this branch currently working smoothly on production with private S3 storage.
DirectUrl::direct_fog_url(with_path: true) should probably be deprecated as it just calls url.