Escape all remaining reserved chars in direct_fog_url #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URI regexp pattern for rel_segment
RESERVED = ";/?:@&=+$,\\[\\]"
rel_segment = ( unreserved | escaped |
";" | "@" | "&" | "=" | "+" |
"$" | "," )
shirshendu
force-pushed
the
master
branch
3 times, most recently
from
248804d to
af31a08
Compare
URI.escape is deprecated for usage with paths
|
This has been fixed on master by letting carrierwave generate the urls with #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes using direct_fog_url with files that have these
?:[]in the filename.From URI::Parser
URI regexp pattern for rel_segment
RESERVED = ";/?:@&=+$,[]"
rel_segment = ( unreserved | escaped |
";" | "@" | "&" | "=" | "+" |
"$" | "," )
Hence, '?:[]' need to be escaped for the URI path to not throw exceptions on parsing.