Correctly respect NoWarn CLI/Task options in Compatibility logging interface #46061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Logging/MSBuildLog.cs
Show resolved
Hide resolved
| { | ||
| Console.WriteLine(messageTextWithCode); | ||
| } | ||
| } |
There was a problem hiding this comment.
Considering we now know this code can break consumers like it happened with aspnetcore, I think we should have a couple tests to verify the behavior.
There was a problem hiding this comment.
Agreed. I filed #46062 to track adding a new test project for the apicompat global tool.
ericstj
approved these changes
Jan 16, 2025
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Logging/ConsoleLog.cs
Outdated
Show resolved
Hide resolved
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Logging/ConsoleLog.cs
Outdated
Show resolved
Hide resolved
carlossanlop
approved these changes
Jan 17, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/aspnetcore#59853