Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 10.0.100-alpha.1.25067.4 #59853

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Updates the .NET SDK to version 10.0.100-alpha.1.25063.8, which also updates the .NET runtime from version 10.0.0-alpha.1.25052.4 to version 10.0.0-alpha.1.25062.3.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 10.0.100-alpha.1.25063.8.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners January 13, 2025 12:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 13, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2025

❌.dotnet\sdk\10.0.100-alpha.1.25063.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'System.ServiceModel.Internals.dll' in any of the provided search directories.
❌.dotnet\sdk\10.0.100-alpha.1.25063.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'SMDiagnostics.dll' in any of the provided search directories.
❌.dotnet\sdk\10.0.100-alpha.1.25063.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP1002: Could not resolve reference 'Microsoft.NET.StringTools.dll' in any of the provided search directories.

@carlossanlop @ViktorHofer looks like you guys have been touching APICompat over the past week or so, does this failure look familiar? dotnet/sdk#45807

@carlossanlop
Copy link
Member

@carlossanlop @ViktorHofer looks like you guys have been touching APICompat over the past week or so, does this failure look familiar? dotnet/sdk#45807

I'll take a closer look at my change but it basically just made changes around logging. No other behaviors should've changed.

@carlossanlop
Copy link
Member

Okay, one change we made was to stop logging CP1002, which is the error shown in this issue:

https://github.com/dotnet/sdk/pull/45807/files#diff-9b4f11ad017bb8ab9b999da096d137319060b5f14c81c170f4404df7568ea9c5

- // Assembly loading ids
-        public const string AssemblyReferenceNotFound = "CP1002";

@ViktorHofer should we bring this back? That removal was part of the extra suggestions in the PR.

@ViktorHofer
Copy link
Member

Yes, the failure is from dotnet/sdk#45807 and need a reaction here. We intentionally made a breaking change as CP1002 warnings didn't make sense to include in the suppression file. I'll push a commit.

The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 16, 2025

I submitted dotnet/sdk#46059 to fix this in a better way. .NET Framework has a set of dangling internal only assemblies that should never get loaded. The PR is taking care of that so that our customers won't these false positives as well.

Meanwhile, I pushed a commit to suppress the CP1002 diagnostics.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2025

Thanks!

@ViktorHofer ViktorHofer changed the title Update .NET SDK to 10.0.100-alpha.1.25063.8 Update .NET SDK to 10.0.100-alpha.1.25067.2 Jan 17, 2025
@ViktorHofer
Copy link
Member

Needs another SDK update

@ViktorHofer ViktorHofer changed the title Update .NET SDK to 10.0.100-alpha.1.25067.2 Update .NET SDK to 10.0.100-alpha.1.25067.4 Jan 17, 2025
@ViktorHofer
Copy link
Member

I don't understand why this new CP1002 is suddenly showing up. I will debug this offline.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ViktorHofer!

@wtgodbe wtgodbe merged commit 87070ed into main Jan 17, 2025
27 checks passed
@wtgodbe wtgodbe deleted the update-dotnet-sdk-10.0.100-alpha.1.25063.8 branch January 17, 2025 23:58
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants