-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET SDK to 10.0.100-alpha.1.25067.4 #59853
Conversation
Update .NET SDK to version 10.0.100-alpha.1.25063.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving SDK update.
@carlossanlop @ViktorHofer looks like you guys have been touching APICompat over the past week or so, does this failure look familiar? dotnet/sdk#45807 |
I'll take a closer look at my change but it basically just made changes around logging. No other behaviors should've changed. |
Okay, one change we made was to stop logging CP1002, which is the error shown in this issue: - // Assembly loading ids
- public const string AssemblyReferenceNotFound = "CP1002"; @ViktorHofer should we bring this back? That removal was part of the extra suggestions in the PR. |
Yes, the failure is from dotnet/sdk#45807 and need a reaction here. We intentionally made a breaking change as CP1002 warnings didn't make sense to include in the suppression file. I'll push a commit. |
Resolves the false positive warnings in dotnet/aspnetcore#59853
The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
I submitted dotnet/sdk#46059 to fix this in a better way. .NET Framework has a set of dangling internal only assemblies that should never get loaded. The PR is taking care of that so that our customers won't these false positives as well. Meanwhile, I pushed a commit to suppress the CP1002 diagnostics. |
Thanks! |
src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj
Outdated
Show resolved
Hide resolved
Needs another SDK update |
I don't understand why this new CP1002 is suddenly showing up. I will debug this offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ViktorHofer!
Updates the .NET SDK to version
10.0.100-alpha.1.25063.8
, which also updates the .NET runtime from version10.0.0-alpha.1.25052.4
to version10.0.0-alpha.1.25062.3
.This pull request was auto-generated by GitHub Actions.