Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better nil transaction checking for commits #8787

Merged
merged 5 commits into from
Jan 24, 2025
Merged

better nil transaction checking for commits #8787

merged 5 commits into from
Jan 24, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jan 23, 2025

No description provided.

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f863263 ok 5937457
version total_tests
f863263 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than before for sure

go/libraries/doltcore/sqle/database_provider.go Outdated Show resolved Hide resolved
@jycor jycor changed the title debug panic better nil transaction checking for commits Jan 23, 2025
@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a8fcada ok 5937457
version total_tests
a8fcada 5937457
correctness_percentage
100.0

@jycor jycor merged commit f19ceef into main Jan 24, 2025
18 checks passed
@jycor jycor deleted the james/test branch January 24, 2025 00:42
@BrewTestBot BrewTestBot mentioned this pull request Jan 24, 2025
Merged
@nicktobey nicktobey mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycor @coffeegoddd @zachmu