Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
The read replica code that compares remote refs and local refs to determine which local refs need to be deleted when synchronizing a read replica from a remote had a problem where certain patterns of ref names could cause the code to select the wrong local refs to remove. These removed refs would not be present on the replica until a future synchronization run recreated them.
The fix for this is to use the
Ref.String()
method (instead ofRef.GetPath()
) to get a unique identifier for the ref (e.g.refs/tags/t1
) and to ensure that the remote and local ref lists are both sorted by that unique identifier.nil
transaction checking forcommit
sdrop temporary table ...
andshow create table
statementsaddresses the related issue here: Stored procedure: temp table created in procedure not visible dolthub/dolt#8762
Bumps undici from 5.28.4 to 5.28.5.
Release notes
Sourced from undici's releases.
Commits
6139ed2
Bumped v5.28.5711e207
Backport of c2d78cd[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=undici&package-manager=npm_and_yarn&previous-version=5.28.4&new-version=5.28.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dolthub/dolt/network/alerts).
Testing Dolt's
caching_sha2_password
auth support with themysql
client on MacOS recently started failing with:mysql: command not found
These tests were previously working, but the
mysql
client seems to no longer be available. This change adds a new step to ensure the current LTSmysql
client is installed.These tests normally run nightly, but they passed in an earlier CI run on this PR that triggered them.
This PR implements the implicit commit logic introduced in this PR implicit commit on ddl statements dolthub/go-mysql-server#2818
On error,
dolt table import -c
does not create the table, and we did that by simply rolling back the existing transaction.Since DDL statements now implcitly
COMMIT
, we need to start a new transaction, and possibly drop any tables created.fixes MySQL DDL ignores autocommit transactionality dolthub/dolt#7485
maybe fixes: Multiple Users report "table not found" errors when using Dolt under concurrency dolthub/dolt#8716
Created the dolt_help system table. This table is meant to store documentation for system tables, procedures, functions, and variables. Currently dolt_help is only populated with documentation for procedures, and only procedures that have equivalent CLI commands.
Part of #7984
go-mysql-server
drop temporary table ...
and displaytemporary in show create table statements
In-memory database doesn't support temporary tables, so tests are here: implement and test
drop temporary table ...
andshow create table
statements dolthub/dolt#8781fixes:
SHOW CREATE TABLE
doesn't includeTEMPORARY
for temporary tables dolthub/dolt#7992last_insert_id
when 0 is specified for the auto_increment column valuefixes:
last_insert_id
gives 0 when 0 is explicitly specified for anauto_increment
primary key in an insertion dolthub/dolt#8769Adding extra strings to the end of an enum type doesn't change the values for any of the existing strings. A table rewrite isn't necessary in this case.
If a specific table implementation does need to be rewritten when an enum type changes this way, they can still implement
ShouldRewriteTable
in order to force a rewrite anyway.Certain queries ignore autocommit, and will implicitly commit the transaction.
vitess
drop temporary table ...
ALTER TABLE
statementsparses more partition options as no-ops
fixes: Parser support for adding/removing partition dolthub/dolt#8744
Closed Issues
SHOW CREATE TABLE
doesn't includeTEMPORARY
for temporary tableslast_insert_id
gives 0 when 0 is explicitly specified for anauto_increment
primary key in an insertion