Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing MacOS BATS tests #8773

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix failing MacOS BATS tests #8773

merged 2 commits into from
Jan 22, 2025

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 21, 2025

Testing Dolt's caching_sha2_password auth support with the mysql client on MacOS recently started failing with: mysql: command not found

These tests were previously working, but the mysql client seems to no longer be available. This change adds a new step to ensure the current LTS mysql client is installed.

These tests normally run nightly, but they passed in an earlier CI run on this PR that triggered them.

@fulghum fulghum force-pushed the fulghum/fix-mac-os-bats branch 2 times, most recently from 1dedfc9 to df31247 Compare January 21, 2025 20:12
@fulghum fulghum force-pushed the fulghum/fix-mac-os-bats branch from df31247 to 74cff56 Compare January 21, 2025 23:14
@fulghum fulghum marked this pull request as ready for review January 21, 2025 23:16
@fulghum fulghum requested a review from jycor January 21, 2025 23:16
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit cb47ee1 into main Jan 22, 2025
1 check passed
@fulghum fulghum deleted the fulghum/fix-mac-os-bats branch January 22, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants