Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/UI tweaks persistent menu nav #35663

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+15 −10
Open

Rc/UI tweaks persistent menu nav #35663

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
991759a
completely hide persistent menu region on nav home
Robert-Costello Jan 22, 2025
43a4660
prefactor use const
Robert-Costello Jan 22, 2025
fdb5b77
shrink collapsed container
Robert-Costello Jan 22, 2025
be0b9ea
let button overhang container and add span to expand click area
Robert-Costello Jan 22, 2025
bfd318e
stop button from triggering menu expansion. slippery button is hard t…
Robert-Costello Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions corehq/apps/cloudcare/templates/cloudcare/partials/menu/persistent_menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
{% load i18n %}

<script type="text/template" id="persistent-menu-template">
<div id="persistent-menu-container" class="d-none d-lg-block bg-white h-100 position-absolute border-end border-dark-subtle border-1"
<div id="persistent-menu-container"
class="d-none d-lg-block bg-white h-100 position-absolute border-end border-dark-subtle border-1 overflow-visible"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

learned something new overflow-visible

style="width: 30px;"
aria-labelledby="persistent-menu-label">
<button id="persistent-menu-arrow-toggle"
class="btn btn-md btn-outline-primary rounded-circle position-absolute top-50 d-flex justify-content-center align-items-center"
style="right: -18px;"
role="button"
aria-label="Expand Persistent Menu"
tabindex="1"
aria-expanded="true"
aria-controls="persistent-menu-container"
class="btn btn-outline-primary me-1 rounded-circle position-absolute top-50 end-0">
aria-controls="persistent-menu-container">
<i class="fa fs-3 fa-chevron-right"></i>
<span></span>
<span class="position-absolute"
style="width: 60px; height: 60px;">
</span>
</button>
<div id="persistent-menu-container-content" class="d-none text-break">
<h2 class="title position-relative me-4" id="persistent-menu-label">
Expand Down