Rc/UI tweaks persistent menu nav #35663
Open
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
Robert-Costello
requested review from
a team,
AddisonDunn,
minhaminha and
Jtang-1
and removed request for
a team
Robert-Costello
requested review from
orangejenny,
biyeun,
MartinRiese,
stephherbers and
nospame
as code owners
That is strange (and unexpected). I'll take a look. |
MartinRiese
approved these changes
Jan 23, 2025
| @@ -1,18 +1,22 @@ | |||
| {% load i18n %} | |||
|
|
|||
| <script type="text/template" id="persistent-menu-template"> | |||
| <div id="persistent-menu-container" class="d-none d-lg-block bg-white h-100 position-absolute border-end border-dark-subtle border-1" | |||
| <div id="persistent-menu-container" | |||
| class="d-none d-lg-block bg-white h-100 position-absolute border-end border-dark-subtle border-1 overflow-visible" | |||
There was a problem hiding this comment.
learned something new overflow-visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This adds a couple of UI changes to the persistent menu as part of the GA process.
Technical Summary
Change Management doc
Feature Flag
persistent_menu_setting
Safety Assurance
Safety story
tested locally and on staging
Automated test coverage
not covered by automated tests
QA Plan
no QA planned
Rollback instructions
Labels & Review