Linted most of the linty bits of app manager #35653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
millerdev,
mjriley,
gherceg,
jingcheng16,
nospame and
MartinRiese
3 tasks
MartinRiese
approved these changes
Jan 22, 2025
|
|
||
| // Callback for when comment update is successful | ||
| // Arguments: name, comment | ||
| var _updateCallbackFn = function () {}; |
There was a problem hiding this comment.
is the linter complaining about the unused name and comment here?
|
Seems pretty save but maybe merge after deploy so it can sit on staging for longer than a few hours |
|
@MartinRiese sounds reasonable, I'll wait to merge |
|
Resolved conflict, ready to merge now. |
MartinRiese
reviewed
Jan 23, 2025
corehq/apps/app_manager/static/app_manager/spec/download_async_modal_spec.js
Show resolved
Hide resolved
MartinRiese
approved these changes
Jan 24, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Prep for migrating app manager to webpack.
All that's left is
app_manager/js/forms/case_config_ui,app_manager/js/settings/commcare_settings, and all theuse strictwarnings. I don't have the wherewithal to do those right now.Safety Assurance
Safety story
Code review is a sufficient safety check. The one
==to===is the only not-quite-mechanical change, and I'm pretty confident that$jqueryThing.val()always return a string, number, or array (docs).Automated test coverage
Not really.
QA Plan
No.
Rollback instructions
Labels & Review