[webpack] App manager tests #35662
Merged
[webpack] App manager tests #35662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
commented
Jan 22, 2025
| 'use strict'; | ||
| const uiElementKeyValueList = hqImport("hqwebapp/js/ui_elements/bootstrap3/ui-element-key-val-list"); | ||
|
|
||
| hqDefine("app_manager/js/forms/form_workflow", [ |
orangejenny
commented
Jan 22, 2025
| @@ -1,4 +1,22 @@ | |||
| hqDefine('app_manager/js/releases/releases', function () { | |||
| hqDefine("app_manager/js/releases/releases", [ | |||
|
Linting in #35653 |
biyeun
reviewed
Jan 23, 2025
| import sinon from "sinon/pkg/sinon"; | ||
|
|
||
| import Toggles from "hqwebapp/js/toggles"; | ||
| import FormWorkflow from "app_manager/js/forms/form_workflow"; |
There was a problem hiding this comment.
is it possible to do an import statement like
import {FormWorkflow} from "app_manager/js/forms/form_workflow";
so that we avoid the FormWorkflow.FormWorkflow situation below?
There was a problem hiding this comment.
hmm nvm perhaps that isn't possible because it's not importing from an ESM module
There was a problem hiding this comment.
I'd need to update the return value of app_manager/js/forms/form_workflow and therefore the other code that depends on that module. I might get there - I don't like FormWorkflow. FormWorkflow either - but not in this PR.
biyeun
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safety Assurance
Safety story
This is largely test code. The main risk is that adding explicit dependencies to
releases.jsandform_workflow.jscould have introduced problems: because these are used on pages that don't use js bundling at all and rely on script tags instead, all of the dependencies are loaded synchronously at the time the file is loaded, which means that all dependencies' script tags need to have already been included.Automated test coverage
It's mostly tests. I smoke tested the releases page and the form workflow UI.
QA Plan
No.
Rollback instructions
Labels & Review