Apply whitelist strictly - fail when misconfigured #35435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
esoergel
requested review from
MartinRiese,
minhaminha,
Jtang-1 and
Robert-Costello
esoergel
force-pushed
the
es/form-submission-whitelist-2
branch
from
cbe28fd to
c741bf2
Compare
esoergel
force-pushed
the
es/form-submission-whitelist-2
branch
from
c741bf2 to
bcc2a3c
Compare
MartinRiese
approved these changes
Jan 22, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
https://dimagi.atlassian.net/browse/USH-4115
Follow-up to #35434
To be merged once we're confident the FF has been enabled for domains that would otherwise be broken by the change.
Change management comms
Feature Flag
OPEN_SUBMISSION_ENDPOINT
Safety Assurance
Safety story
I also back-populated the FF for all domains on www and india that had triggered the sentry error since Sept 24, 2024 (the oldest data we have available).
Automated test coverage
QA Plan
Rollback instructions
Labels & Review