[WIP] Check mobile endpoints access across the board. #30761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except form submission, as that handles things very differently
I'm not totally certain of the _noauth_post endpoint, but from looking at it, it's probably best to default to locking it down
esoergel
added
Open for review: do not merge
dimagimon
added
the
Risk: High
snopoke
approved these changes
Nov 23, 2021
corehq/apps/ota/views.py
Outdated
| @@ -79,7 +79,6 @@ | |||
| @location_safe | |||
| @handle_401_response | |||
| @mobile_auth_or_formplayer | |||
There was a problem hiding this comment.
not really related but why does the restore endpoint need mobile_auth_or_formplayer? Is it because SMS forms don't have user auth?
There was a problem hiding this comment.
yep, I believe that's the case.
commcare-hq/corehq/apps/domain/decorators.py
Lines 361 to 364 in d5b9a30
The restore endpoint is the only place that mechanism is used.
|
deployed to staging yesterday |
3 tasks
dimagimon
removed
the
Risk: High
|
This PR has (finally) been superseded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Restrict access to all mobile endpoints when "restrict mobile endpoints" feature flag is enabled. I've done some testing on staging, and this seems to behave as expected, with one tangential caveat.
Note that this does also disable non-sensitive mobile operations like device log submissions, heartbeat, and so forth, though I think that's fine, as the idea is that nobody should be using mobile without permissions.
I think the only blocker on merge here is that we likely have APIs submitting to the mobile submission endpoint. We'll need to move them over to the new API submission endpoint before we can close that up.
Feature Flag
USH: Require explicit permissions to access mobile app endpoints
Safety Assurance
Safety story
Automated test coverage
QA Plan
I tested this on staging and found the expected behavior:
Rollback instructions
Labels & Review