Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 btn style #33945

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Bootstrap 5 btn style #33945

merged 3 commits into from
Jan 8, 2024

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Jan 4, 2024

Product Description

The btn-xs style was a recreation of the one on Bootstrap3. But Bootstrap 5's btn-sm is equivalent so use that instead.

Technical Summary

Based on this comment #33902 (comment)

Feature Flag

No

Safety Assurance

Safety story

only style change for Bootstrap 5

Automated test coverage

no automated tests

QA Plan

no QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@Jtang-1 Jtang-1 requested a review from biyeun January 4, 2024 22:01
@Jtang-1 Jtang-1 mentioned this pull request Jan 4, 2024
3 tasks
@Jtang-1 Jtang-1 marked this pull request as ready for review January 4, 2024 22:04
@Jtang-1 Jtang-1 requested a review from orangejenny as a code owner January 4, 2024 22:04
Copy link
Member

@biyeun biyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Jtang-1 Jtang-1 requested a review from biyeun January 5, 2024 22:42
@Jtang-1 Jtang-1 merged commit 00fc1fb into master Jan 8, 2024
12 checks passed
@Jtang-1 Jtang-1 deleted the jt/bootstrap5-remove-btn-xs-style branch January 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants