File Upload Button Style #33902
File Upload Button Style #33902
Conversation
Jtang-1
added
the
product/all-users-all-environments
| @@ -1,8 +1,16 @@ | |||
| @import "../../../../../../node_modules/bootstrap/less/buttons.less"; | |||
There was a problem hiding this comment.
That's a gnarly import. But it does seem to be how we do it in other places.
| .btn-group-xs > .btn, .btn-xs { | ||
| padding: 1px 5px; | ||
| font-size: 12px; | ||
| line-height: 1.5; | ||
| border-radius: 3px; | ||
| } |
There was a problem hiding this comment.
What is this set of styles needed for?
There was a problem hiding this comment.
btn-xs no longer exists for bootstrap 5 so this style recreates it
|
hey @Jtang-1, for the future, the solution to missing classes for the bootstrap migration should not be to add the missing style. In the case of bootstrap 5, The migration helper script covers cc @nospame |
|
@Jtang-1 see Bootstrap's Migration guide for the full explanation of dropping the |
Product Description
Changes style of "Choose File" button to match other CommCare buttons. More generally, this affects all buttons of an
inputelement oftype="file". This is a platform level change,.Before:
After:
Technical Summary
Jira Ticket: https://dimagi-dev.atlassian.net/browse/USH-3937
Feature Flag
No feature flag
Safety Assurance
Safety story
tested locally and on staging. Limited to style change.
Automated test coverage
no auomated test
QA Plan
No QA.
Rollback instructions
Labels & Review