Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_manual_search to request for case search validation #33905

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

stephherbers
Copy link
Contributor

@stephherbers stephherbers commented Dec 20, 2023

Support Ticket: USH-4011

Product Description

Help performance for vase search validation (has reached 10+ seconds on production)

Technical Summary

Suggested by Shubham, based on the problematic app: "This is because the default_search is set to true for the module (Skip to ES search results) and even though Web Apps passes execute as false , FP perform ES search for modules with default_search set. To override the default_search Web Apps also need to pass the force_manual_search as true for requests where we don’t want to do the search. "

Feature Flag

Case Search

Safety Assurance

Safety story

This will be tested on staging to ensure it does not break workflow

Automated test coverage

Not too many in this area

QA Plan

I am not requesting QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Dec 20, 2023
@stephherbers stephherbers added the product/feature-flag Change will only affect users who have a specific feature flag enabled label Dec 20, 2023
@stephherbers stephherbers marked this pull request as ready for review December 20, 2023 21:25
@Jtang-1 Jtang-1 merged commit 295a8eb into master Dec 20, 2023
12 checks passed
@Jtang-1 Jtang-1 deleted the smh/default_search-mod branch December 20, 2023 22:55
@Jtang-1 Jtang-1 mentioned this pull request Dec 21, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/feature-flag Change will only affect users who have a specific feature flag enabled Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants