Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fixes named parameter #33906

Merged
merged 1 commit into from
Dec 21, 2023
Merged

bug: fixes named parameter #33906

merged 1 commit into from
Dec 21, 2023

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Dec 21, 2023 •
edited
Loading

Product Description

invisible

Resulting payload from navigate_menu
Screen Shot 2023-12-21 at 9 17 32 AM

Technical Summary

This PR fixes a typo such that #33905 achieves intended change.

Feature Flag

Safety Assurance

Safety story

Automated test coverage

See original PR

QA Plan

no QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Dec 21, 2023
@Jtang-1 Jtang-1 marked this pull request as ready for review December 21, 2023 17:48
@Jtang-1 Jtang-1 requested a review from esoergel December 21, 2023 17:48
@Jtang-1 Jtang-1 merged commit d8d701c into master Dec 21, 2023
12 checks passed
@Jtang-1 Jtang-1 deleted the jt/forceManualSearch-for-case-search-validation branch December 21, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esoergel esoergel esoergel approved these changes

@nospame nospame Awaiting requested review from nospame nospame is a code owner

@shubham1g5 shubham1g5 Awaiting requested review from shubham1g5

Assignees
No one assigned
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jtang-1 @esoergel @dimagimon