Support xpc_connection_set_peer_sig on macOS 12 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
approved these changes
Nov 21, 2023
Also support validating client code requirements using the audit token using the same APIs.
steven-joruk
force-pushed
the
sj/code-signature
branch
from
733bf07 to
3e220ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds built in support for client validation using audit tokens on macOS <= 11.x if the audit_token feature is enabled.
If users try to use client validation without the audit_token feature enabled on macOS <= 11.x then clients will silently be rejected. I've opened an issue to discuss adding logging.
I tested this on macOS 11 with the audit_token feature enabled and disabled, with and without code signing requirements enabled, and using clients that match and do not match the code signing requirements.
I'll add some tests soon, I'll think about the best way to drive them with the different combinations of code signing and multiple build configurations.